Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [CCI] Update the default branch in changelog.js #797

Closed
andreymyssak opened this issue May 29, 2023 · 3 comments · Fixed by #1050
Closed

[BUG] [CCI] Update the default branch in changelog.js #797

andreymyssak opened this issue May 29, 2023 · 3 comments · Fixed by #1050
Assignees
Labels
bug Something isn't working CCI College Contributor Initiative good first issue Good for newcomers

Comments

@andreymyssak
Copy link
Collaborator

Describe the bug

The default branch is now main and therefore the main section is not removed from the changelog.

const changelogSource = require('!!raw-loader!../../../../CHANGELOG.md').default.replace(
/## \[`master`\].+?##/s, // remove the `master` heading & contents
'##'
);

To Reproduce
Steps to reproduce the behavior:

  1. Open http://localhost:8030/#/package/changelog
  2. See the main section

Expected behavior
The main section must be hidden

OpenSearch Version
Main branch (localhost)

Screenshots
Screenshot 2023-05-29 at 11 17 36

@andreymyssak andreymyssak added bug Something isn't working untriaged labels May 29, 2023
@BSFishy BSFishy removed the untriaged label May 29, 2023
@SergeyMyssak SergeyMyssak added the CCI College Contributor Initiative label Jun 16, 2023
@joshuarrrr joshuarrrr added the good first issue Good for newcomers label Oct 10, 2023
@BigSamu
Copy link
Contributor

BigSamu commented Oct 16, 2023

@joshuarrrr @BSFishy,

I would like to work on this issue

@BSFishy BSFishy linked a pull request Oct 16, 2023 that will close this issue
7 tasks
@BSFishy
Copy link
Contributor

BSFishy commented Oct 16, 2023

Oops, sorry @BigSamu this is worked on in #1050. Forgot to tag the issue!

@BSFishy BSFishy assigned BSFishy and unassigned BigSamu Oct 16, 2023
@BigSamu
Copy link
Contributor

BigSamu commented Oct 16, 2023

No worries @BSFishy ! Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CCI College Contributor Initiative good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants