Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate iconType and iconProps from OuiPageHeader #644

Closed
KrooshalUX opened this issue Mar 29, 2023 · 2 comments
Closed

Deprecate iconType and iconProps from OuiPageHeader #644

KrooshalUX opened this issue Mar 29, 2023 · 2 comments
Assignees
Labels

Comments

@KrooshalUX
Copy link
Contributor

As including an icon in our page header is not part of our guidance moving forward, we should deprecate the use of iconType and iconProps from OuiPageHeader, as well as update the corresponding OUI documentation page (remove the props from the props tab, and in any of the playground areas it may still be visible).

Thanks to @joshuarrrr for the suggestion!

          @KrooshalUX Do we want a follow-up issue to actually remove/deprecate the `<OuiPageHeader>` `iconType` prop?

Originally posted by @joshuarrrr in #625 (comment)

@abbyhu2000 abbyhu2000 added CCI College Contributor Initiative good first issue Good for newcomers and removed CCI College Contributor Initiative labels Apr 11, 2023
@curq
Copy link
Contributor

curq commented May 10, 2023

Can I take this issue please?

@BSFishy
Copy link
Contributor

BSFishy commented May 10, 2023

For reference, this work should be done in 2 PR's:

  1. Deprecate the prop by adding a doc comment and a console warning
  2. Actually remove the prop

This will make sure we can backport the deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

5 participants