Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Docs) Modal #176

Closed
1 task done
Tracked by #112
KrooshalUX opened this issue Dec 30, 2022 · 2 comments · Fixed by #237
Closed
1 task done
Tracked by #112

(OUI Docs) Modal #176

KrooshalUX opened this issue Dec 30, 2022 · 2 comments · Fixed by #237
Assignees
Labels

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Dec 30, 2022

Tab: Examples
Section: Loading and disabling confirm button > Show loading confirm modal

  • After you type "delete" and click "Delete button" you are shown a message that reads "SHAME ON YOU". Remove "Shame on you" from appearing (for clarity this means do not have any follow up message show at all, not just the copy removal)
@KrooshalUX KrooshalUX changed the title Modal (OUI Docs) Modal Dec 30, 2022
@kgcreative
Copy link
Member

kgcreative commented Dec 31, 2022

So this triggers a "Delete with friction" modal, with "Delete the OUI repo?", and when you type delete and click the Delete button, it gives the "Shame on you!" alert message, which seems like an attempt for cheeky humor. Should we change the popup prompt as well to say something like "Delete the selected resource?" instead, followed by a "resource successfully deleted" toast instead of the additional confirmation message, which appears to be a "browser default

@KrooshalUX
Copy link
Contributor Author

I was going to originally prescribe a toast be added but to keep focus on the demo of modal, I went without it. Happy to bring it back; was worried about adding complexity until we wrote guidance around modals being followed by toasts (which accounts for most verification use cases but I wanted to consider other possible cases as well).

@BSFishy BSFishy added the documentation Improvements or additions to documentation label Jan 12, 2023
@KrooshalUX KrooshalUX added OUIDocs v2.6.0 and removed documentation Improvements or additions to documentation labels Jan 12, 2023
@KrooshalUX KrooshalUX linked a pull request Feb 3, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants