Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Deprecate public methods and variables that contain 'master' terminology in class 'NoMasterBlockService' and 'MasterService' #4038

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e65aaca from #4006

…ogy in class 'NoMasterBlockService' and 'MasterService' (#4006)

Deprecates public methods and variables that contain 'master' terminology
in class NoMasterBlockService and MasterService. Unit tests are also
added to ensure consistency with the new naming.

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit e65aaca)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners July 28, 2022 19:37
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4038 (4528ddb) into 2.x (5d1dc07) will increase coverage by 0.22%.
The diff coverage is 78.12%.

@@             Coverage Diff              @@
##                2.x    #4038      +/-   ##
============================================
+ Coverage     70.37%   70.59%   +0.22%     
- Complexity    56347    56449     +102     
============================================
  Files          4529     4529              
  Lines        271885   271894       +9     
  Branches      39989    39990       +1     
============================================
+ Hits         191328   191935     +607     
+ Misses        64453    63819     -634     
- Partials      16104    16140      +36     
Impacted Files Coverage Δ
...org/opensearch/cluster/service/ClusterService.java 80.55% <0.00%> (ø)
.../opensearch/common/util/concurrent/BaseFuture.java 62.71% <0.00%> (ø)
...g/opensearch/cluster/coordination/Coordinator.java 79.46% <50.00%> (+1.57%) ⬆️
.../org/opensearch/cluster/service/MasterService.java 83.19% <62.50%> (+0.13%) ⬆️
...nsearch/cluster/coordination/JoinTaskExecutor.java 90.90% <100.00%> (+2.97%) ⬆️
...ter/coordination/NoClusterManagerBlockService.java 95.65% <100.00%> (-4.35%) ⬇️
...ster/coordination/AbstractCoordinatorTestCase.java 92.68% <100.00%> (-0.65%) ⬇️
...c/main/java/org/opensearch/test/RandomObjects.java 90.25% <100.00%> (-4.55%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
... and 485 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments deprecate v2.2.0 labels Jul 28, 2022
@tlfeng tlfeng merged commit 1d68b52 into 2.x Jul 28, 2022
@tlfeng tlfeng deleted the backport/backport-4006-to-2.x branch July 28, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments deprecate enhancement Enhancement or improvement to existing feature or request v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants