Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Integration tests are failing in dependabot PRs #194

Closed
dblock opened this issue Oct 17, 2024 · 3 comments · Fixed by #195
Closed

[BUG] Integration tests are failing in dependabot PRs #194

dblock opened this issue Oct 17, 2024 · 3 comments · Fixed by #195
Labels
bug Something isn't working good first issue Good for newcomers untriaged Issues that require attention from the maintainers.

Comments

@dblock
Copy link
Member

dblock commented Oct 17, 2024

What is the bug?

CI/CD got stale, integration tests are failing in Dependabot PRs.

How can one reproduce the bug?

See failures in any of https://github.com/opensearch-project/opensearch-sdk-py/pulls.

What is the expected behavior?

CI/CD to be green.

@dblock dblock added bug Something isn't working good first issue Good for newcomers labels Oct 17, 2024
@github-actions github-actions bot added the untriaged Issues that require attention from the maintainers. label Oct 17, 2024
@dbwiddis
Copy link
Member

dbwiddis commented Oct 18, 2024

CI/CD got stale

2 issues.

  1. OpenSearch is not even compiling. Offending PR merged 2 weeks ago.
  2. Gradle has deprecated features. Offending PR (update to Gradle 8.20 merged 2 months ago.
FAILURE: Build completed with 2 failures.
> Task :server:compileJava FAILED
...
> Compilation failed; see the compiler error output for details.

Looks like it's set for strict javadoc checking

/home/runner/work/opensearch-sdk-py/opensearch-sdk-py/opensearch/server/src/main/java/org/opensearch/action/pagination/PaginationStrategy.java:48: error: no tag name after @
     * Utility method to get list of indices filtered as per {@param filterPredicate} and the sorted according to {@param comparator}.
                                                             ^
/home/runner/work/opensearch-sdk-py/opensearch-sdk-py/opensearch/server/src/main/java/org/opensearch/action/pagination/PaginationStrategy.java:48: error: no tag name after @
     * Utility method to get list of indices filtered as per {@param filterPredicate} and the sorted according to {@param comparator}.
                                                                                                                  ^
/home/runner/work/opensearch-sdk-py/opensearch-sdk-py/opensearch/server/src/main/java/org/opensearch/action/pagination/PaginationStrategy.java:60: error: no tag name after @
     * Utility method to get list of indices sorted as per {@param comparator}.

Those @param should probably be @link.

We may be able to work around it by adding -x javadoc to the gradle build until the above is fixed.

@dbwiddis
Copy link
Member

This should fix 1 of 2 problems:

Other possible problem is Gradle-9 incompatible features, we can add a switch to our gradle command in CI to not fail on deprecation. Let's get the java one fixed first.

@dbwiddis
Copy link
Member

dbwiddis commented Oct 18, 2024

We should also use Java 17 in our integration GHA. Or maybe even 21 since we're using OpenSearch main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers untriaged Issues that require attention from the maintainers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants