Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Deliverables for Create Detector for AD Extension #59

Closed
owaiskazi19 opened this issue Jul 22, 2022 · 2 comments
Closed

[PROPOSAL] Deliverables for Create Detector for AD Extension #59

owaiskazi19 opened this issue Jul 22, 2022 · 2 comments
Labels

Comments

@owaiskazi19
Copy link
Member

What are you proposing?

  1. Comment out all the code of the AD plugin and have only the create detector code for AD. Make sure the build is successful and AD plugin is able to run the feature create detector.

  2. For creating the detector,

    • Let's just focus on CreateIndexRequest by sending a request to OpenSearch consisting of ANOMALY_DETECTORS_INDEX and let OpenSearch create the index.

    • Also, an ActionListener to detect the failure if any.

      create

  3. As we are not focusing on Security in the first phase of deliverable

    • We will comment out the user validation and also avoid using FILTER_BY_BACKEND_ROLES role required currently for AD plugin
    • Since SDK will be our client to make a request call to OpenSearch. We can comment out the client currently present in the AD plugin codebase
  4. Integrate SDK with AD plugin and make it run as an extension with OpenSearch

@dbwiddis
Copy link
Member

We will comment out the user validation and also avoid using FILTER_BY_BACKEND_ROLES role required currently for AD plugin

Instead of commenting user out, we can pass null as user for now, which bypasses the role filtering. See #23

Since SDK will be our client to make a request call to OpenSearch. We can comment out the client currently present in the AD plugin codebase

This could either be replaced by a null placeholder or dozens of method signatures need to be rewritten to remove this parameter. Discuss on #22.

@dbwiddis
Copy link
Member

Hey @owaiskazi19 can this issue be closed now that we've created the detector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants