-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add identity/authorization headers into Rest Client calls #430
Comments
Hello @dbwiddis , I would like to take this issue |
Hey @kokibas happy for you to work on this, but I'll be honest the requirement is a little vague here. Let me know if you have any questions! |
@dbwiddis have identity features been completed? |
Hello @dbwiddis ,I wanted to ask In order to change Request Options and add headers, I need to call the "toBuilder()" method of the RequestOptions class in SDKClient class , creating a new instance of the Builder class containing the current parameters that can be changed. Then I have to call the Builder methods to add headers to Request Options. Finally, the modified Request Options can be set in the request by calling the "set Request Options()" method.Can you tell me if I understood the task correctly. |
Yes, I believe that is the correct approach. Here is code in a test class doing that. |
Done in #613 |
Is your feature request related to a problem?
Presently
SDKClient
rest calls do not include security features. Upcoming integration of identity features will include authentication and/or identity tokens that will need to be included with REST requests via the client.See opensearch-project/OpenSearch#3846
What solution would you like?
SDKClient REST calls need to edit the
RequestOptions
to add headers.There may be a need to close/re-initialize the clients or just change the headers, that will need to be determined later.
The text was updated successfully, but these errors were encountered: