Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate SDK design and integrate AnomalyDetection Indices #160

Closed
9 of 12 tasks
owaiskazi19 opened this issue Sep 27, 2022 · 2 comments
Closed
9 of 12 tasks

Incorporate SDK design and integrate AnomalyDetection Indices #160

owaiskazi19 opened this issue Sep 27, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@owaiskazi19
Copy link
Member

owaiskazi19 commented Sep 27, 2022

Is your feature request related to a problem?

Initialize searchFeatureDao, anomalyDetectionIndices, adTaskManager objects using the Transport APIs created here.

The following items have been completed for the above objects:

  • Change constructors to match SDK createComponents method
  • Replace environmentSettings calls with new API
  • Replace AdSettingConsumer calls with new API
  • Remove clusterService and replace functionality
  • Replace client index and delete requests in AnomalyDetectionIndices.java]
  • Replace all adminClient create requests in AnomalyDetectionIndices.java
  • Replace adminClient clusterState request in AnomalyDetectionIndices.java
  • Replace adminClient getAliases() and rolloverIndexRequest() in AnomalyDetectionIndices.java
  • Remove ActionListener from AnomalyDetectionIndices.java

Remaining tasks:

  • Replace adminClient putMapping() in AnomalyDetectionIndices.java
  • Research how to use the SearchResponse from SDK client as a replacement for NodeClient for search requests in SearchFeatureDao.java and AdTaskManager.java
  • Replace all client calls in SearchFeatureDao.java, AdTaskManager.java, and HashRing.java
@minalsha
Copy link
Collaborator

@ryanbogan is there a draft PR for workitems completed for this? If so, could you please provide a link to it. Thanks

@dbwiddis
Copy link
Member

@ryanbogan is there a draft PR for workitems completed for this? If so, could you please provide a link to it. Thanks

@minalsha here's the PR: opensearch-project/anomaly-detection#684

I'm closing this issue as I've integrated everything from this issue and that draft PR, except for the HashRing which is covered by #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants