Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DCO Workflow Check #80

Closed
2 tasks done
Tracked by #17
peternied opened this issue Sep 30, 2021 · 5 comments
Closed
2 tasks done
Tracked by #17

Ensure DCO Workflow Check #80

peternied opened this issue Sep 30, 2021 · 5 comments

Comments

@peternied
Copy link
Member

peternied commented Sep 30, 2021

Coming from opensearch-project/project-meta#17

A Developer Certificate of Origin is required on commits in the OpenSearch-Project.

See doc.yml for an example workflow. Ensure CONTRIBUTING.md to has a section on the DCO per the project template.

  • DCO Check Workflow
  • CONTRIBUTING.md DCO Section
@peternied peternied changed the title Ensure Ensure DCO Workflow Check Sep 30, 2021
@vchrombie
Copy link
Contributor

A Developer Certificate of Origin is required on commits in the OpenSearch-Project.

Nice 👍

Even the CHAOSS Charter requires that contributions are accompanied by a Developer Certificate of Origin sign-off. For ensuring it, a bot checks all incoming commits.

See doc.yml for an example workflow.

  • DCO Check Workflow

Just wanted to comment about the other options available. The dco bot can be configured at the organization level and it doesn't need any github action workflows.

Example:

Please feel free to proceed with whatever option the organization maintainers prefer.
Thanks.

@peternied
Copy link
Member Author

peternied commented Sep 30, 2021

Initially we considered using that DCO bot and choose not to due to its requirement to access private repositories. Instead we built our own check with Jenkins CI for only a handful of repositories, but we never offered an option to smaller repos. This workflow makes it simple to get all our repos in.

@vchrombie
Copy link
Contributor

Okay, thanks for the reply. I think the github actions is the right tool for your usecase. 👍

@peternied
Copy link
Member Author

@vchrombie Can we get the DCO check added on this repo? This is literally the last one in the campaign

@vchrombie
Copy link
Contributor

@vchrombie Can we get the DCO check added on this repo? This is literally the last one in the campaign

Yes, I don't have any problem with it. Please proceed with whatever suits the requirement.
Thanks.

@CEHENKLE CEHENKLE mentioned this issue Nov 11, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants