Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for JDK 14 #132

Closed
14 tasks done
Tracked by #1624
dblock opened this issue Mar 17, 2022 · 10 comments
Closed
14 tasks done
Tracked by #1624

Drop support for JDK 14 #132

dblock opened this issue Mar 17, 2022 · 10 comments
Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New feature or request v2.0.0

Comments

@dblock
Copy link
Member

dblock commented Mar 17, 2022

Is your feature request related to a problem?

In OpenSearch 1.3.0 we stopped testing the complete distribution with JDK 15 in favor of 11, so we can't make claims on compatibility with JDK 15. Plugins never built with JDK15 individually.

The easiest thing to do is probably to just re-add JDK15 to CI matrices so that we can reclaim this compatibility.

But we could also drop JDK 14.

What solution would you like?

Re-add JDK15 to the CI matrix.

or

Remove JDK14 from the CI matrix.

Update: we decided to drop support for JDK 14

@dblock dblock added enhancement New feature or request untriaged v2.0.0 labels Mar 17, 2022
@dblock dblock changed the title [FEATURE] Add JDK 15 into the CI matrix Re-Add JDK 15 into the CI matrix Mar 17, 2022
@dblock dblock changed the title Re-Add JDK 15 into the CI matrix Add JDK 15 into the CI matrix Mar 17, 2022
@dblock
Copy link
Member Author

dblock commented Mar 18, 2022

@dlvenable Want to comment on whether we should be dropping 14 instead of adding 15?

@dblock dblock changed the title Add JDK 15 into the CI matrix Add JDK 15 into the CI matrix? Remove JDK 14? Mar 18, 2022
@dlvenable
Copy link
Member

Why would anybody run against either JDK 14 or 15? The only reason I can is that these were (until recently) the "official" versions of OpenSearch. So some users may have decided to run on these JDKs and may have installed them on their clusters.

I suggest that starting in 2.0, OpenSearch only claims compatibility with LTS versions (11 and 17 presently).

It would be valuable to run tests against the latest version of non-LTS Java in order to catch issues which may arise. It could be nice to know that OpenSearch stops working with, say JDK 19.

@peternied
Copy link
Member

From a resourcing perspective, I vote for Remove JDK14 from the CI

@dlvenable
Copy link
Member

I agree with the vote Remove JDK14 from the CI matrix..

There may be value to keeping it in 1.x since it has been supported in OpenSearch 1.x. But I certainly think there is no reason to test 14 or 15 in 2.x.

@vamsi-amazon
Copy link
Member

I agree with vote Remove JDK14 from the CI matrix. Similar to the lines of Java, Opensearch should be compatible with LTS versions JDK11 and JDK17.

@ylwu-amzn
Copy link

I think we should keep in 1.x for better backward compatibility. We can remove JDK14 from 2.0 as big version can tolerate some breaking change.

@peternied
Copy link
Member

Its been a week now, I do not see any opinions suggesting that we add support for JDK15, making this a once sided issue. @dblock was there any other channels you wanted to get feedback from before we make a decision?

@dblock
Copy link
Member Author

dblock commented Mar 29, 2022

I'd like public comment, but I am waiting on opensearch-project/project-website#670 to be published to ask.

@reta
Copy link

reta commented Mar 30, 2022

+1 to Remove JDK14 from the CI matrix.

@dblock
Copy link
Member Author

dblock commented Mar 30, 2022

Looks like no votes for keeping JDK14. I'm updating the issue and creating sub-issues in projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New feature or request v2.0.0
Projects
None yet
Development

No branches or pull requests

6 participants