From 54fd5a216b5fde7b6ab03d2481d18f32a2268390 Mon Sep 17 00:00:00 2001 From: magoz Date: Wed, 1 Feb 2023 18:15:34 +0100 Subject: [PATCH 1/3] Add missing types for AwsSigv4SignerOptions.service Signed-off-by: magoz --- lib/aws/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/aws/index.d.ts b/lib/aws/index.d.ts index a36b701c8..d58ccccb7 100644 --- a/lib/aws/index.d.ts +++ b/lib/aws/index.d.ts @@ -19,6 +19,7 @@ import { OpenSearchClientError } from '../errors'; interface AwsSigv4SignerOptions { getCredentials?: () => Promise; region: string; + service: 'es' | 'aoss'; } interface AwsSigv4SignerResponse { From 822d12484f174119abcee63c28bf0af9f80fea0d Mon Sep 17 00:00:00 2001 From: magoz Date: Wed, 1 Feb 2023 18:22:19 +0100 Subject: [PATCH 2/3] update changelog with Add missing types for AwsSigv4SignerOptions.service Signed-off-by: magoz --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ae46ad302..e8a66f49b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Deprecated ### Removed ### Fixed +- Added missing types for AwsSigv4SignerOptions.service ([#377](https://github.com/opensearch-project/opensearch-js/pull/377)) + + ### Security - [CVE-2022-25912] Bumps simple-git from 3.4.0 to 3.15.0 ([#341](https://github.com/opensearch-project/opensearch-js/pull/341)) From f4e9e043c1ae9c62e50113cd7708949bf8f6276c Mon Sep 17 00:00:00 2001 From: magoz Date: Tue, 14 Feb 2023 18:49:09 +0100 Subject: [PATCH 3/3] fix: service is optional Signed-off-by: magoz --- lib/aws/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/aws/index.d.ts b/lib/aws/index.d.ts index d58ccccb7..3d8e5c652 100644 --- a/lib/aws/index.d.ts +++ b/lib/aws/index.d.ts @@ -19,7 +19,7 @@ import { OpenSearchClientError } from '../errors'; interface AwsSigv4SignerOptions { getCredentials?: () => Promise; region: string; - service: 'es' | 'aoss'; + service?: 'es' | 'aoss'; } interface AwsSigv4SignerResponse {