From 0bb24a48a3aa62b4795a015ef4996c062209b8cb Mon Sep 17 00:00:00 2001 From: Magoz Date: Sat, 28 Jan 2023 07:49:45 +0100 Subject: [PATCH 1/3] Added service option 2.2.0 added support for AOSS, but the types weren't updated. --- lib/aws/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/aws/index.d.ts b/lib/aws/index.d.ts index a36b701c8..d58ccccb7 100644 --- a/lib/aws/index.d.ts +++ b/lib/aws/index.d.ts @@ -19,6 +19,7 @@ import { OpenSearchClientError } from '../errors'; interface AwsSigv4SignerOptions { getCredentials?: () => Promise; region: string; + service: 'es' | 'aoss'; } interface AwsSigv4SignerResponse { From 048d282726130b0000d1df53f006529afe910c20 Mon Sep 17 00:00:00 2001 From: magoz Date: Tue, 31 Jan 2023 19:14:00 +0100 Subject: [PATCH 2/3] Revert "Added service option" This reverts commit 0bb24a48a3aa62b4795a015ef4996c062209b8cb. --- lib/aws/index.d.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/aws/index.d.ts b/lib/aws/index.d.ts index d58ccccb7..a36b701c8 100644 --- a/lib/aws/index.d.ts +++ b/lib/aws/index.d.ts @@ -19,7 +19,6 @@ import { OpenSearchClientError } from '../errors'; interface AwsSigv4SignerOptions { getCredentials?: () => Promise; region: string; - service: 'es' | 'aoss'; } interface AwsSigv4SignerResponse { From b6b981aa02daa33f86fe128e2b6f3b281b916cb0 Mon Sep 17 00:00:00 2001 From: magoz Date: Tue, 31 Jan 2023 19:21:15 +0100 Subject: [PATCH 3/3] Add missing types for AwsSigv4SignerOptions.service Signed-off-by: magoz --- CHANGELOG.md | 3 ++- lib/aws/index.d.ts | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 94ebe22bc..57ff5c8fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Fixed - Fix mutability of connection headers ([#291](https://github.com/opensearch-project/opensearch-js/issues/291)) +- Added missing types for AwsSigv4SignerOptions.service ([#374](https://github.com/opensearch-project/opensearch-js/pull/374)) [2.1]: https://github.com/opensearch-project/opensearch-js/releases/tag/2.1.0 -[Unreleased]: https://github.com/opensearch-project/opensearch-js/compare/2.1...HEAD \ No newline at end of file +[Unreleased]: https://github.com/opensearch-project/opensearch-js/compare/2.1...HEAD diff --git a/lib/aws/index.d.ts b/lib/aws/index.d.ts index a36b701c8..d58ccccb7 100644 --- a/lib/aws/index.d.ts +++ b/lib/aws/index.d.ts @@ -19,6 +19,7 @@ import { OpenSearchClientError } from '../errors'; interface AwsSigv4SignerOptions { getCredentials?: () => Promise; region: string; + service: 'es' | 'aoss'; } interface AwsSigv4SignerResponse {