Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] service parameter missing in AwsSigv4SignerOptions #491

Closed
nand-biz4group opened this issue Apr 13, 2023 · 2 comments
Closed

[BUG] service parameter missing in AwsSigv4SignerOptions #491

nand-biz4group opened this issue Apr 13, 2023 · 2 comments
Labels
🐛 bug Something isn't working good first issue Good for newcomers

Comments

@nand-biz4group
Copy link

image

interface AwsSigv4SignerOptions {
getCredentials?: () => Promise;
region: string;
service?:string;
}
Because it is required in opensearch serverless
image

@nhtruong nhtruong added good first issue Good for newcomers and removed untriaged labels Apr 13, 2023
@gauravbiz4group
Copy link

I think it's already resolved in GitHub repo code:
alreadyresolved
but not updated on the npm package:
internalfile

@dblock
Copy link
Member

dblock commented Apr 14, 2023

Fixed in #377 already, but please double-check @nand-biz4group that the version on HEAD works for you? We need to release 2.3, add your +1 to #303 please.

@dblock dblock closed this as completed Apr 14, 2023
@wbeckler wbeckler added the 🐛 bug Something isn't working label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants