Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the "Blacklist / Whitelist" nomenclature in nodejs client #223

Closed
ananzh opened this issue Apr 21, 2022 · 3 comments
Closed

Change the "Blacklist / Whitelist" nomenclature in nodejs client #223

ananzh opened this issue Apr 21, 2022 · 3 comments
Assignees

Comments

@ananzh
Copy link
Member

ananzh commented Apr 21, 2022

OpenSearch repository is going to replace the terminology "blacklist / whitelist" with "denylist / allowlist".
issue: opensearch-project/OpenSearch#1483, with the plan for its terminology replacement.

Although the existing usages with "master" will be supported in OpenSearch version 2.x to keep the backwards compatibility, please prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.
All the OpenSearch REST APIs and settings that contain "master" terminology will be deprecated in 2.0, and alternative usages will be added.

Describe the solution you'd like
Replace the terminology "blacklist" with "denylist".
Replace the terminology "whitelist" with "allowlist".

When being compatible with OpenSearch 2.0:

Replace "blacklist" in descriptive text
Replace "whitelist" in descriptive text and internal variable name
Replace "whitelist" in setting name
Replace "whitelist" in documentation

@ananzh
Copy link
Member Author

ananzh commented Apr 21, 2022

Blacklist

let { ${genQueryBlacklist(false)}, ...querystring } = params

@ananzh
Copy link
Member Author

ananzh commented Apr 21, 2022

Whitelist

Data:/test/fixtures/stackoverflow.ndjson (1 mention)

@ananzh
Copy link
Member Author

ananzh commented May 20, 2022

Solved by:
#224

Close it

@ananzh ananzh closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant