-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Send search request query DSL json directly to search request #525
Comments
Thanks @wbeckler. yes that would do the job. Closing this issue |
Reopening as the real need is a similar feature supported by the Elasticsearch Java Client here (https://www.elastic.co/guide/en/elasticsearch/client/java-api-client/7.17/loading-json.html) |
I really like the description used in the es docs, i agree that my teams normal workflow is using kibana to make some custom query, then directly using that json in the high level rest client. I would like for that to still be possible in the future, as the high level rest client gets deprecated there still needs to be a way to go from json request to any endpoint in kibana to being able to send that as a request in my java app. |
For bookkeeping, in what way is #377 different? Also would love to see a PR ;) |
I wholeheartedly agree that we this feature should be prioritised. In that case there is nothing we can do and the api is useless for us, since the deserialiser will produce the wrong query... We are constructing the request body using a library and would like to be able to pass the Json body directly to the "search" endpoint. Maybe we could have something like this Please, correct me if I am wrong but that does not seem like a tall task, wouldn't we need to just modify the code that serialises the json prior to create a request and use the raw json passed? |
I think so, I am not sure why the previous attempts haven't worked. Take it up @brentam! |
Is your feature request related to a problem?
Data Prepper is going to support configurable queries that will utilize the opensearch java client for search requests.
The query DSL is being taken is as a json string, and the opensearch java client does not support passing a
Map
or json string to pass this query DSL directly.However, the opensearch java client requires queries to be modeled using the opensearch java client classes
What solution would you like?
An option to pass the search request directly to the
SearchRequest
class instead of having to model it piece by pieceWhat alternatives have you considered?
modeling the entirety of a search request in Java in Data Prepper. This does not scale well
Do you have any additional context?
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: