Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove push event triggers in all workflow #1108

Closed
SuZhou-Joe opened this issue Feb 17, 2024 · 4 comments
Closed

[FEATURE] Remove push event triggers in all workflow #1108

SuZhou-Joe opened this issue Feb 17, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request untriaged

Comments

@SuZhou-Joe
Copy link
Member

Is your feature request related to a problem?

The push triggered flow fails to launch as it requests checkout action first before doing path-filter.

What solution would you like?

Remove the useless push event as all the commit happens with a pull request, we do not allow contributors to push to a branch directly.

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7938831230/job/21678772804?pr=1107

@SuZhou-Joe SuZhou-Joe added enhancement New feature or request untriaged labels Feb 17, 2024
@SuZhou-Joe SuZhou-Joe self-assigned this Feb 17, 2024
@wanglam
Copy link
Collaborator

wanglam commented Feb 18, 2024

@SuZhou-Joe Will the pull request events re-run after new commits pushed?

@Hailong-am
Copy link
Collaborator

pull event might be useful for fork repos to test changes. Also @ruanyl have a PR #1017 to solve similar issue.

@SuZhou-Joe
Copy link
Member Author

pull event might be useful for fork repos to test changes. Also @ruanyl have a PR #1017 to solve similar issue.

I see, didn't know that.

@ruanyl
Copy link
Member

ruanyl commented Mar 28, 2024

Closing this issue as it's fixed in #1017

@ruanyl ruanyl closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

4 participants