Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release promotion pipeline enhancements #4750

Closed
gaiksaya opened this issue Jun 6, 2024 · 3 comments · Fixed by #4753
Closed

Release promotion pipeline enhancements #4750

gaiksaya opened this issue Jun 6, 2024 · 3 comments · Fixed by #4753
Assignees
Labels
enhancement New Enhancement

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Jun 6, 2024

Is your feature request related to a problem? Please describe

With #4748 closed, we were able to bring down the pipeline runtime from 1 hour 6min (1.3.16 release run) to 21min (1.3.17 release run) which is around 68%. However, there are still few other jobs that are manually triggered today.

Listing them here:

  • Docker promotion workflow
  • Maven promotion workflow
  • Manually invalidate cloudfront
  • Validation workflow for all platforms/arch

Other enhancements that are out of the scope of this issue are:

  • Manual Validation for core native plugins (example: respository-s3) [RELEASE] Release version 1.3.17 #4659 (comment)
  • Adding validation for APT repo
  • Increasing the validation time for windows artifacts since its takes 15min for the CI docker image to be pulled on windows agent.

Describe the solution you'd like

Add above workflows to automated centralized pipeline bringing us closer to #3676

Describe alternatives you've considered

No response

Additional context

No response

@gaiksaya gaiksaya added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jun 6, 2024
@peterzhuamazon
Copy link
Member

Add on top of this list, we can also add things like:

  • Tag repos after release
  • Update manifests with tag
  • Send helm/ansible PRs
  • Cut tag on infra
  • More......

to the central release workflow too.

My concern is that we should have a resume function because the central promotion pipeline includes too many steps now. We do not want to switch back to manual trigger if one step failed in the process.

Thanks.

@gaiksaya
Copy link
Member Author

gaiksaya commented Jun 7, 2024

@peterzhuamazon IMO the workflows that you mentioned can be added into new central workflow for post release activities. central-post-release-workflows WDYT? Trying to keep promotion job as promotion only.
Adding @prudhvigodithi @rishabh6788 to the conversation.

@peterzhuamazon
Copy link
Member

@peterzhuamazon IMO the workflows that you mentioned can be added into new central workflow for post release activities. central-post-release-workflows WDYT? Trying to keep promotion job as promotion only. Adding @prudhvigodithi @rishabh6788 to the conversation.

Yeah that would also be good so we can separate these two.
Each would take max about 30min and could be easily restarted as well.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants