Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Adding support for --single-version loose as part of build_workflow #4345

Closed
peterzhuamazon opened this issue Jan 12, 2024 · 5 comments
Labels
cicd enhancement New Enhancement

Comments

@peterzhuamazon
Copy link
Member

Hi,
Adding support for --single-version loose as part of build_workflow.

This is just a small potential improvement, as @AMoo-Miki has added a support for relaxing dependency check for OSD plugins.
opensearch-project/OpenSearch-Dashboards#5675

We can add a new param such as --osd-loose-deps-check or similar if needed.
Thanks.

@prudhvigodithi
Copy link
Member

[Triage]
There is some discussion happening on this PR #4343.

@peterzhuamazon
Copy link
Member Author

We might not need this anymore. See #4343.

@derek-ho derek-ho reopened this Feb 19, 2024
@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label Feb 19, 2024
@derek-ho
Copy link
Contributor

@peterzhuamazon can you help out here for path forward? We recently see this issue come up again after OSD core listed cypress 9.X as a dependency:

[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "@elastic/eslint-import-resolver-kibana > [email protected]" has unmet peer dependency "eslint-plugin-import@>=1.4.0".
warning " > @testing-library/[email protected]" has unmet peer dependency "react@>=16.9.0".
warning "@testing-library/react-hooks > [email protected]" has unmet peer dependency "react@>=16.13.1".
warning "cypress-mochawesome-reporter > [email protected]" has unmet peer dependency "mocha@>=7".
warning " > [email protected]" has unmet peer dependency "eslint@>= 3.2.1".
[4/4] Building fresh packages...

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      If you have questions about this please reach out to the operations team.

      The conflicting dependencies are:

        cypress
          9.5.4 => opensearch-dashboards
          ^13.6.0 => opensearch-security-dashboards

Adding --single-version=loose fixes it on the local CI, but autocuts are still open since the build process doesn't incorporate this parameter. Path forward is either for OSD core to ignore dev dependencies, or to add this flag to the build process to prevent autocuts. Thanks!

@derek-ho
Copy link
Contributor

Autocut issue: opensearch-project/security-dashboards-plugin#1786
PR that introduced cypress to OSD core: opensearch-project/OpenSearch-Dashboards#5725

@peterzhuamazon
Copy link
Member Author

Seems running fine in 2.13 version.
Close for now.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd enhancement New Enhancement
Projects
Development

No branches or pull requests

4 participants