Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component.yml to get required information #3381

Closed
2 tasks done
Tracked by #1274
gaiksaya opened this issue Apr 10, 2023 · 5 comments
Closed
2 tasks done
Tracked by #1274

Update component.yml to get required information #3381

gaiksaya opened this issue Apr 10, 2023 · 5 comments
Assignees
Labels
enhancement New Enhancement

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Apr 10, 2023

Is your feature request related to a problem? Please describe

The consolidated test manifest can retrieve plugin information for existing component.yml.
Hence this needs to be updated with below values

component_name: alerting
status: failure/success
test_config: with-security
test_run_id: b30b804a1a3e494089b720544627dd2e
test_type: integ-test
files:
- https://{BASE_URL}/{COMPONT_PATH}/stderr.txt
- https://{BASE_URL}/{COMPONT_PATH}/stdout.txt
- https://{BASE_URL}/{COMPONT_PATH}/local-cluster-logs/stderr.txt
- https://{BASE_URL}/{COMPONT_PATH}/local-cluster-logs/stdout.txt
- https://{BASE_URL}/{COMPONT_PATH}/local-cluster-logs/opensearch-service-logs/opensearch.log
...

Describe the solution you'd like

Update component.yml to get required values

Describe alternatives you've considered

No response

Acceptance Criteria

  • component.yml should contain all the above information mentioned in the description
  • component.yml should do the heavy lifting of containing all the required information and test-report manifest should only combine all that information to the its own schema
@prudhvigodithi
Copy link
Member

[Triage]
Adding @zelinh please add the next action items when you get a chance.

@zelinh
Copy link
Member

zelinh commented Apr 17, 2023

A specific example of the new component yml file sql.yml should be looking like below.

component_name: alerting
status: failure/success
test_config: with-security
test_run_id: abcd1234
test_type: integ-test
files:
- https://{BASE_URL}/{COMPONT_PATH}/stderr.txt
- https://{BASE_URL}/{COMPONT_PATH}/stdout.txt
  local-cluster-logs:
    - https://{BASE_URL}/{COMPONT_PATH}/local-cluster-logs/stderr.txt
    - https://{BASE_URL}/{COMPONT_PATH}/local-cluster-logs/stdout.txt
    - https://{BASE_URL}/{COMPONT_PATH}/local-cluster-logs/opensearch-service-logs/opensearch.log
    - https://{BASE_URL}/{COMPONT_PATH}/local-cluster-logs/opensearch-service-logs/opensearchcluster1.log
    - ...

Currently the stderr.txt & stdout.txt for the component test is located in another test-results subfolder like {COMPONT_PATH}/test-results/stderr.txt. We are looking to remove it and have these logs directly in the component path.
Besides, we have a new sub-directory from files that will include links/paths to stderr.txt & stdout.txt and include all the opensearch-service-logs from the local test cluster should be also included.

@zelinh
Copy link
Member

zelinh commented May 3, 2023

From my investigation, the test_recorder would record stderr & stdout along with component yml file before local_cluster_logs recorded. Therefore the local_cluster_logs addressed in the above example are not available when the component yaml file is generated in our current implement.
Can also be seeing in the logs here. Reproducible with command: ./test.sh integ-test manifests/2.7.0/opensearch-2.7.0-test.yml --component sql -p opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.7.0/7771/linux/x64/tar --test-run-id 1234

2023-05-03 22:25:48 INFO     Recording component test results for sql at /usr/share/opensearch/opensearch-build/test-results/1234/integ-test/sql/with-security
2023-05-03 22:25:48 INFO     Sending SIGKILL to PID 13520
2023-05-03 22:25:48 INFO     Process killed with exit code None
2023-05-03 22:25:48 INFO     Recording local cluster logs for sql with test configuration as with-security at /usr/share/opensearch/opensearch-build/test-results/1234/integ-test/sql/with-security/local-cluster-logs

I'm looking into the implementation further to find how we could accomplish this design.

@zelinh zelinh moved this from Backlog to In Progress in OpenSearch Engineering Effectiveness May 4, 2023
@zelinh
Copy link
Member

zelinh commented May 5, 2023

Right now I'm able to generate the enhanced component yaml file with mock url links from integ test.

[opensearch@92677c32ca49 opensearch-build]$ cat test-results/1234/integ-test/sql/with-security/sql.yml
component_name: sql
test_config: with-security
test_result: PASS
test_run_id: 1234
test_type: integ-test
test_result_files:
- https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/stdout.txt
- https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/stderr.txt
- local-cluster-logs:
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/stdout.txt
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/stderr.txt
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_server.json
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1.log
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_task_detailslog.json
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_index_indexing_slowlog.json
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_deprecation.json
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/gc.log
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_index_indexing_slowlog.log
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_index_search_slowlog.json
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_deprecation.log
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_task_detailslog.log
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/opensearchcluster1_index_search_slowlog.log
  - https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/test-results/1234/integ-test/sql/with-security/local-cluster-logs/opensearch-service-logs/gc.log.00

with command

./test.sh integ-test manifests/2.7.0/opensearch-2.7.0-test.yml --component sql -p opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.7.0/7771/linux/x64/tar --test-run-id 1234 --base-path https://ci.opensearch.org/ci/dbc/integ-test/2.7.0/7771/linux/x64/tar/

Working actively to get the PR ready.

@zelinh
Copy link
Member

zelinh commented May 25, 2023

Closing this issue as this is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
Development

No branches or pull requests

3 participants