-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] What does latest
url referring to in ci.opensearch.org
#1973
Comments
Old |
I believe latest should refer to the latest stable and supported release. RC1, Alpha, and Beta releases should require users to have to explicitly opt-in (by manually selecting a version). This I have come expect when using the use the latest tag from any other projects. |
since this is ci.opensearch (as opposed to artifacts.opensearch) i wouldn't expect
If a red tarball breaks downstream CIs then I would prefer option 1, otherwise i would prefer option 2 as currently reports-scheduler CI is broken because upstream rc1 missing opensearch-project/reporting#341 |
@dtaivpp You misunderstood as this Thanks. |
+1 If there is a failure, assets that were available are not longer present, that is not very useful for automated processes. In the use case of the security plugin, opensearch-min is used to install the security plugin and verify service still comes up. We had issues in the past where we broke the distribution build and it wasn't discovered until after a week. |
@peterzhuamazon I am so glad I misunderstood! haha that would have been a bad UX 😅 |
Sorry that my original description is not clear enough so I added some context now. |
I think this makes more sense because it will take a lot of the usefulness out of |
I prefer this definition. Successfully compiled code that doesn't pass all tests, aka doesn't work (🔴) is not very useful and will yield too many false positives downstream when consumed. |
IM code is trying to get This is why I support using 2 as 1 cause the above failure. |
@peterzhuamazon Although this problem surfaces in our use of |
Have some conversation with @amitgalitz offline and we will try to resolve this issue with maven zips after 2.0.0. |
We will keep using the |
Hi All,
In ci.opensearch.org staging repo we use
latest
keyword to replace to the latest build number, e.g.2400
.latest
full 🟢 build (x64/arm64 tar/rpm all green).latest build
, no matter 🔴 or 🟢 statushttps://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.0.0-rc1/latest/linux/x64/tar/dist/opensearch/opensearch-2.0.0-rc1-linux-x64.tar.gz
We are having 1 right now, which means there is guaranteed to have a working tarball with latest, but not always the latest code.
This means, in
2.0.0-rc1
right now due to rpm failure, there is no latest url available yet for CI to use, even though tarball is built already.Since there are a lot of plugin repo CIs use
latest
, if we go with 2 it might break CIs more often if any of tar/rpm build goes red.Thanks.
The text was updated successfully, but these errors were encountered: