Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python Typechecking] Final push pipenv run mypy . #1513

Closed
Tracked by #1237
peternied opened this issue Jan 18, 2022 · 0 comments · Fixed by #2123
Closed
Tracked by #1237

[Python Typechecking] Final push pipenv run mypy . #1513

peternied opened this issue Jan 18, 2022 · 0 comments · Fixed by #2123
Assignees
@dblock
Labels
enhancement New Enhancement good first issue Good for newcomers

Comments

@peternied
Copy link
Member

peternied commented Jan 18, 2022 •
edited
Loading

See full instructions at #1237

Note; this should be the last type checking task completed otherwise there will be some duplication with those tasks

Acceptance criteria:

  • Run pipenv run mypy . passes without error
@peternied peternied mentioned this issue Jan 18, 2022
Closed
8 tasks
@peternied peternied changed the title Final push pipenv run mypy . [Python Typechecking] Final push pipenv run mypy . Jan 18, 2022
@peternied peternied added enhancement New Enhancement good first issue Good for newcomers labels Jan 25, 2022
@dblock dblock mentioned this issue May 14, 2022
Merged
@dblock dblock self-assigned this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dblock dblock

Labels
enhancement New Enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing typings. dblock/opensearch-build
2 participants
@dblock @peternied