Remove JCenter Dependencies #1456

peternied · 2022-01-12T17:35:14Z

See the OpenSearch Forum Announcement

Execution failed for task ':buildSrc:compileJava'.
> Could not resolve all files for configuration ':buildSrc:compileClasspath'.
   > Could not resolve org.apache.maven:maven-model:3.6.2.
     Required by:
         project :buildSrc

Reproduce with
./build.sh manifests/1.2.4/opensearch-1.2.4.yml --component OpenSearch --snapshot

Full Error stack

> Task :buildSrc:reaper:check UP-TO-DATE
> Task :buildSrc:reaper:build
> Task :buildSrc:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':buildSrc:compileJava'.
> Could not resolve all files for configuration ':buildSrc:compileClasspath'.
   > Could not resolve org.apache.maven:maven-model:3.6.2.
     Required by:
         project :buildSrc
      > Could not resolve org.apache.maven:maven-model:3.6.2.
         > Could not parse POM https://jcenter.bintray.com/org/apache/maven/maven-model/3.6.2/maven-model-3.6.2.pom
            > Could not resolve org.apache.maven:maven:3.6.2.
               > Could not resolve org.apache.maven:maven:3.6.2.
                  > Could not parse POM https://jcenter.bintray.com/org/apache/maven/maven/3.6.2/maven-3.6.2.pom
                     > Could not resolve org.apache.maven:maven-parent:33.
                        > Skipped due to earlier error
   > Could not resolve org.apache.ant:ant-launcher:1.10.9.
     Required by:
         project :buildSrc > org.apache.ant:ant:1.10.9
      > Skipped due to earlier error
   > Could not resolve com.perforce:p4java:2015.2.1365273.
     Required by:
         project :buildSrc > com.netflix.nebula:gradle-info-plugin:7.1.3
      > Skipped due to earlier error
   > Could not resolve com.netflix.nebula:gradle-contacts-plugin:5.1.0-rc.1.
     Required by:
         project :buildSrc > com.netflix.nebula:gradle-info-plugin:7.1.3
      > Skipped due to earlier error
   > Could not resolve org.eclipse.jgit:org.eclipse.jgit:5.0.1.201806211838-r.
     Required by:
         project :buildSrc > com.netflix.nebula:gradle-info-plugin:7.1.3
      > Skipped due to earlier error
   > Could not resolve org.tmatesoft.svnkit:svnkit:1.8.12.
     Required by:
         project :buildSrc > com.netflix.nebula:gradle-info-plugin:7.1.3
      > Skipped due to earlier error
   > Could not resolve org.apache.rat:apache-rat-core:0.13.
     Required by:
         project :buildSrc > org.apache.rat:apache-rat:0.13
      > Skipped due to earlier error
   > Could not resolve org.apache.rat:apache-rat-tasks:0.13.
     Required by:
         project :buildSrc > org.apache.rat:apache-rat:0.13
      > Skipped due to earlier error
   > Could not resolve org.slf4j:slf4j-api:1.7.25.
     Required by:
         project :buildSrc > com.networknt:json-schema-validator:1.0.36
      > Skipped due to earlier error
   > Could not resolve org.apache.commons:commons-lang3:3.5.
     Required by:
         project :buildSrc > com.networknt:json-schema-validator:1.0.36
      > Skipped due to earlier error
   > Could not resolve org.jruby.joni:joni:2.1.31.
     Required by:
         project :buildSrc > com.networknt:json-schema-validator:1.0.36
      > Skipped due to earlier error
   > Could not resolve com.fasterxml.jackson.core:jackson-annotations:2.12.5.
     Required by:
         project :buildSrc > com.fasterxml.jackson.core:jackson-databind:2.12.5
         project :buildSrc > com.fasterxml.jackson.core:jackson-databind:2.12.5 > com.fasterxml.jackson:jackson-bom:2.12.5
      > Skipped due to earlier error
   > Could not resolve com.fasterxml.jackson.core:jackson-core:2.12.5.
     Required by:
         project :buildSrc > com.fasterxml.jackson.core:jackson-databind:2.12.5
         project :buildSrc > com.fasterxml.jackson.core:jackson-databind:2.12.5 > com.fasterxml.jackson:jackson-bom:2.12.5
      > Skipped due to earlier error

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 13s
2022-01-12 17:24:33 ERROR    Error building OpenSearch, retry with: ./build.sh manifests/1.2.4/opensearch-1.2.4.yml --component OpenSearch --snapshot
Traceback (most recent call last):
  File "./src/run_build.py", line 78, in <module>
    sys.exit(main())
  File "./src/run_build.py", line 66, in main
    builder.build(build_recorder)
  File "/var/jenkins/workspace/distribution-build-opensearch/src/build_workflow/builder_from_source.py", line 50, in build
    self.git_repo.execute(build_command)
  File "/var/jenkins/workspace/distribution-build-opensearch/src/git/git_repository.py", line 83, in execute
    subprocess.check_call(command, cwd=cwd, shell=True)
  File "/usr/local/lib/python3.7/subprocess.py", line 363, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'bash /var/jenkins/workspace/distribution-build-opensearch/scripts/components/OpenSearch/build.sh -v 1.2.4 -p linux -a x64 -s true -o builds' returned non-zero exit status 1.

What’s the problem?

JCenter, which is a repository used in our builds, ceased operations today. Gradle was pulling dependencies from JCenter, and some repos have a direct dependency on it. This broke that the build process for OpenSearch engine, all branches so that the last successful build of 1.3 was at 7:03 AM PT Jan 12th.

To Fix:

Remove any direct dependency on jcenter(). This would appear in a repositories block in build.gradle. Example.
If your plugin depends on a gradle plugin that cannot currently be downloaded from https://plugins.gradle.org/ because its dependencies are failing to pull from jcenter. A workaround is to define a repositories block at the top of your settings.gradle file that allows us to control the order and first search in maven central.

pluginManagement {
  repositories {
    mavenCentral()
    gradlePluginPortal()
  }
}

Remove JCenter Tasks

The text was updated successfully, but these errors were encountered:

dblock · 2022-01-12T17:43:50Z

jcenter bintray is down, https://isdown.app/integrations/bintray

Do note that jcenter bintray has been sunset, even though it will remain online, we need a campaign to remove our dependency on it.

mch2 · 2022-01-12T18:42:16Z

Been looking at this a bit -

From a
./gradlew build --debug

2022-01-12T10:28:31.122-0800 [DEBUG] [org.gradle.api.internal.artifacts.ivyservice.ivyresolve.RepositoryChainComponentMetaDataResolver] Attempting to resolve component for org.yaml:snakeyaml:1.26 using repositories [BintrayJCenter, opensearch-downloads, opensearch-downloads2, opensearch-snapshots, elasticsearch-downloads, elasticsearch-snapshots, MavenRepo, MavenLocal, MavenRepo2, maven]

Most of these are coming from DistributionDownloader, but I don't see JCenter defined there. I think this is being brought in by gradle.

From https://blog.gradle.org/jcenter-shutdown -

The Gradle Plugin Portal implicitly mirrors JCenter currently. If you’re using the Plugin Portal (via gradlePluginPortal() or the URL plugins.gradle.org/m2) to resolve your application’s dependencies, you may be relying on JCenter. You should avoid using the Plugin Portal as a repository, except for Gradle plugin projects.

We are using this here: https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/build.gradle#L98

mch2 · 2022-01-12T18:52:11Z

Just noticed that 1.x branch is still explicitly referencing jcenter() here

dblock · 2022-01-12T19:11:03Z

Thanks for looking into it @mch2, let's fix OpenSearch on all branches, then I'll cascade this issue into plugins as needed to get rid of anything jcenter.

mch2 · 2022-01-12T19:18:47Z

So I initiated that backport to 1.x to remove the explicit jcenter() dep in 1.x, but its still blowing up. I think the isue is in gradlePluginPortal().

Unfortunately without gradlePluginPortal() defined we are unable to resolve a few dependencies:

Could not determine the dependencies of task ':buildSrc:compileGroovy'.

Could not resolve all task dependencies for configuration ':buildSrc:compileClasspath'.
Could not find com.github.jengelman.gradle.plugins:shadow:6.0.0.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/github/jengelman/gradle/plugins/shadow/6.0.0/shadow-6.0.0.pom
If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
Required by:
project :buildSrc
Could not find com.avast.gradle:gradle-docker-compose-plugin:0.12.1.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/avast/gradle/gradle-docker-compose-plugin/0.12.1/gradle-docker-compose-plugin-0.12.1.pom
If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
Required by:
project :buildSrc

owaiskazi19 · 2022-01-12T19:27:47Z

Apparently spotless also uses jcenter and it's on main.
Could not GET 'https://jcenter.bintray.com/com/diffplug/spotless/spotless-lib/2.7.0/spotless-lib-2.7.0.module'. Received status code 502 from server: Bad Gateway.
https://github.com/opensearch-project/OpenSearch/runs/4793525694?check_suite_focus=true

mch2 · 2022-01-12T19:44:56Z

Tried an explicit dependency on plugins.gradle.org/m2/ instead of gradlePluginPortal() - looks like the version of spotless we are using is not there so it mirrors to jCenter.

A problem occurred configuring root project 'OpenSearch'.
Could not determine the dependencies of null.
Could not resolve all task dependencies for configuration ':classpath'.
> Could not resolve com.diffplug.spotless:spotless-lib:2.7.0.
Required by:
project : > com.diffplug.spotless:com.diffplug.spotless.gradle.plugin:5.6.1 > com.diffplug.spotless:spotless-plugin-gradle:5.6.1
> Could not resolve com.diffplug.spotless:spotless-lib:2.7.0.
> Could not get resource 'https://plugins.gradle.org/m2/com/diffplug/spotless/spotless-lib/2.7.0/spotless-lib-2.7.0.module'.
> Could not GET 'https://jcenter.bintray.com/com/diffplug/spotless/spotless-lib/2.7.0/spotless-lib-2.7.0.module'. Received status code 502 from server: Bad Gateway

dlvenable · 2022-01-12T19:50:08Z

@mch2 , Did you try to disable the Gradle module files as noted here? opensearch-project/OpenSearch#1892 (comment) I see that it is trying to load a .module file.

mch2 · 2022-01-12T20:08:28Z

@mch2 , Did you try to disable the Gradle module files as noted here? opensearch-project/OpenSearch#1892 (comment) I see that it is trying to load a .module file.

Thanks @dlvenable for the suggestion. I've tried it but still getting the same trace. With debug enabled I can see plugins.gradle.com redirecting to bintray. Spotless 5.6.1 declares other spotless dependencies that are sourced from bintray, so it redirects there - ex.

    <dependency>
      <groupId>com.diffplug.spotless</groupId>
      <artifactId>spotless-lib</artifactId>
      <version>2.7.0</version>
      <scope>compile</scope>
      <type>jar</type>
      <optional>false</optional>
    </dependency>

2022-01-12T12:04:55.177-0800 [DEBUG] [org.apache.http.impl.conn.PoolingHttpClientConnectionManager] Connection released: [id: 1][route: {s}->https://plugins.gradle.org:443][total available: 2; route allocated: 2 of 20; total allocated: 2 of 20] 2022-01-12T12:04:55.177-0800 [DEBUG] [org.apache.http.impl.conn.PoolingHttpClientConnectionManager] Connection released: [id: 0][route: {s}->https://plugins.gradle.org:443][total available: 2; route allocated: 2 of 20; total allocated: 2 of 20] 2022-01-12T12:04:55.180-0800 [DEBUG] [org.gradle.internal.resource.transport.http.AlwaysFollowAndPreserveMethodRedirectStrategy] Redirect requested to location 'https://jcenter.bintray.com/com/diffplug/spotless/spotless-lib-extra/2.7.0/spotless-lib-extra-2.7.0.pom' 2022-01-12T12:04:55.180-0800 [DEBUG] [org.gradle.internal.resource.transport.http.AlwaysFollowAndPreserveMethodRedirectStrategy] Redirect requested to location 'https://jcenter.bintray.com/com/diffplug/spotless/spotless-lib/2.7.0/spotless-lib-2.7.0.pom'

mch2 · 2022-01-12T20:14:32Z

Updates from gradle - https://status.gradle.com/?_ga=2.113826690.463275434.1641929099-1662752518.1641929099

dlvenable · 2022-01-12T20:25:55Z

@mch2 , The spotless plugin is also available in Maven Central:
https://repo1.maven.org/maven2/com/diffplug/spotless/spotless-lib/2.7.0/

It seems something is still preferring the load from the Gradle Plugin Repository rather than Maven Central.

I'm currently trying to move Data Prepper plugins to use the classic syntax of apply plugin. It appears this lets us control the order - Maven Central than Gradle Plugins.

mch2 · 2022-01-12T20:30:13Z

@dlvenable yep been trying to figure out how to point there instead of jcenter.

I think this can be done by declaring a repositories block inside of settings.gradle

pluginManagement {
  repositories {
    mavenCentral()
    gradlePluginPortal()
  }
}

Testing it out - so far so good

mch2 · 2022-01-12T20:33:52Z

Yep this worked for me

2022-01-12T12:32:35.273-0800 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationRunner] Build operation 'Download https://repo.maven.apache.org/maven2/com/diffplug/spotless/spotless-lib/2.7.0/spotless-lib-2.7.0.jar' completed
2022-01-12T12:32:35.281-0800 [DEBUG] [org.gradle.api.internal.artifacts.ivyservice.ivyresolve.CachingModuleComponentRepository] Downloaded artifact 'spotless-lib-2.7.0.jar (com.diffplug.spotless:spotless-lib:2.7.0)' from resolver: MavenRepo

dblock · 2022-01-12T20:39:50Z

@mch2 Can I please get some help here - can you edit the issue above with clear instructions of what a project/component/plugin needs to do to fix a similar error? thx

mch2 · 2022-01-12T20:46:17Z

@mch2 Can I please get some help here - can you edit the issue above with clear instructions of what a project/component/plugin needs to do to fix a similar error? thx

will do - testing locally with job-scheduler and will update.

peterzhuamazon · 2022-01-12T21:07:52Z

jcenter bintray is down, https://isdown.app/integrations/bintray

Do note that jcenter bintray has been sunset, even though it will remain online, we need a campaign to remove our dependency on it.

More accurate report link tho their website is having issues: https://status.bintray.com/incidents/d0yvk95zh58j

mch2 · 2022-01-12T21:28:37Z

To mitigate this:

Remove any direct dependency on jcenter(). This would appear in a repositories block in build.gradle. Example.
If your plugin depends on a gradle plugin that cannot currently be downloaded from https://plugins.gradle.org/ because its dependencies are failing to pull from jcenter. A workaround is to define a repositories block at the top of your settings.gradle file that allows us to control the order and first search in maven central.

pluginManagement {
  repositories {
    mavenCentral()
    gradlePluginPortal()
  }
}

peternied · 2022-01-12T21:30:07Z

Thanks @mch2 I've added the fix to the top of this issue

dblock · 2022-01-13T14:54:48Z

@peternied , I don't see this issue tagged to a release, is this a target for 1.2.4 or 1.3 ? fyi - @ps48 - thanks

I labeled this 1.2.4 because we can't produce builds without fixing it.

amitgalitz · 2022-01-13T18:29:19Z

@peternied , I don't see this issue tagged to a release, is this a target for 1.2.4 or 1.3 ? fyi - @ps48 - thanks

I labeled this 1.2.4 because we can't produce builds without fixing it.

Does this mean all fixes on plugin level as well even if build doesn't fail should be backported to 1.2 for 1.2.4 release.

peternied · 2022-01-13T19:22:35Z

@amitgalitz Yes, these changes need to be backported to all branches that we expect to build. This event aside, JCenter will eventually be permanently offline, and we might as well get ahead of it.

If there are BWC tests that pull code and rebuild old versions those branches will need backports as well otherwise those tests will be unable to execute. This might be a good opportunity to check on your BWC tests runs and confirm they are healthy.

peternied · 2022-02-17T17:19:21Z

There are still open subtasks, tracking this down

dblock · 2022-02-17T17:22:01Z

Lots of remaining hits in https://github.com/search?q=org%3Aopensearch-project+jcenter&type=code

peternied · 2022-02-17T17:40:52Z

We've got 22 instances from this query I'll try to drive these all down / create new issues.

peternied · 2022-02-18T16:49:15Z

Down to 10 instances of jcenter, here is an updated query.

peternied · 2022-02-23T23:38:19Z

Down to 5 instances of jcenter

peternied · 2022-02-28T17:24:23Z

There are only 2 outstanding references, both in the alerting plugin

peternied · 2022-02-28T17:25:04Z

RE: opensearch-project/notifications#373 - Notification team is not taking changes at this time.

peternied added the bug Something isn't working label Jan 12, 2022

peternied self-assigned this Jan 12, 2022

mch2 mentioned this issue Jan 12, 2022

Update build.gradle to include job-scheduler jar when staging maven publications. opensearch-project/job-scheduler#117

Merged

5 tasks

saratvemulapalli mentioned this issue Jan 12, 2022

[1.2] Update FIPS API libraries of Bouncy Castle (#1853) opensearch-project/OpenSearch#1888

Merged

5 tasks

mch2 mentioned this issue Jan 12, 2022

[Backport 1.x] Replace JCenter with Maven Central. (#1057) opensearch-project/OpenSearch#1892

Merged

5 tasks

dblock added the v1.2.4 label Jan 13, 2022

This was referenced Jan 14, 2022

Adds workaround repositories block to resolve missing jcenter dependency opensearch-project/index-management#248

Closed

[Distribution Build Failure] Detekt fails to resolve com.beust:jcommander:1.74 opensearch-project/index-management#249

Closed

peternied closed this as completed Jan 26, 2022

peternied reopened this Feb 17, 2022

peternied removed the v1.2.4 label Feb 17, 2022

peternied mentioned this issue Feb 17, 2022

[RELEASE] Release version 1.3.0 #889

Closed

34 tasks

peternied changed the title ~~[Distribution Build Failure] JCenter Build issues - OpenSearch Could not resolve org.apache.maven:maven-model:3.6.2.~~ Remove JCenter Dependencies Feb 17, 2022

peternied added the v1.3.0 label Feb 17, 2022

peternied mentioned this issue Feb 18, 2022

Remove jcenter repository opensearch-project/data-prepper#1062

Closed

peternied mentioned this issue Feb 24, 2022

Remove jcenter repository missed on first pass opensearch-project/common-utils#118

Merged

1 task

peterzhuamazon mentioned this issue Mar 7, 2022

[RELEASE] Release version 2.0.0 (RC1) #1624

Closed

51 tasks

peternied mentioned this issue Mar 8, 2022

Remove references to deprecated service: JCenter opensearch-project/opensearch-java#114

Closed

peternied closed this as completed Mar 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove JCenter Dependencies #1456

Remove JCenter Dependencies #1456

peternied commented Jan 12, 2022 •

edited

Loading

dblock commented Jan 12, 2022

mch2 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dblock commented Jan 12, 2022

mch2 commented Jan 12, 2022 •

edited

Loading

owaiskazi19 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dlvenable commented Jan 12, 2022

mch2 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dlvenable commented Jan 12, 2022

mch2 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dblock commented Jan 12, 2022

mch2 commented Jan 12, 2022

peterzhuamazon commented Jan 12, 2022

mch2 commented Jan 12, 2022

peternied commented Jan 12, 2022

dblock commented Jan 13, 2022

amitgalitz commented Jan 13, 2022

peternied commented Jan 13, 2022

peternied commented Feb 17, 2022

dblock commented Feb 17, 2022

peternied commented Feb 17, 2022 •

edited

Loading

peternied commented Feb 18, 2022

peternied commented Feb 23, 2022

peternied commented Feb 28, 2022

peternied commented Feb 28, 2022

Remove JCenter Dependencies #1456

Remove JCenter Dependencies #1456

Comments

peternied commented Jan 12, 2022 • edited Loading

What’s the problem?

To Fix:

Remove JCenter Tasks

dblock commented Jan 12, 2022

mch2 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dblock commented Jan 12, 2022

mch2 commented Jan 12, 2022 • edited Loading

owaiskazi19 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dlvenable commented Jan 12, 2022

mch2 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dlvenable commented Jan 12, 2022

mch2 commented Jan 12, 2022

mch2 commented Jan 12, 2022

dblock commented Jan 12, 2022

mch2 commented Jan 12, 2022

peterzhuamazon commented Jan 12, 2022

mch2 commented Jan 12, 2022

peternied commented Jan 12, 2022

dblock commented Jan 13, 2022

amitgalitz commented Jan 13, 2022

peternied commented Jan 13, 2022

peternied commented Feb 17, 2022

dblock commented Feb 17, 2022

peternied commented Feb 17, 2022 • edited Loading

peternied commented Feb 18, 2022

peternied commented Feb 23, 2022

peternied commented Feb 28, 2022

peternied commented Feb 28, 2022

peternied commented Jan 12, 2022 •

edited

Loading

mch2 commented Jan 12, 2022 •

edited

Loading

peternied commented Feb 17, 2022 •

edited

Loading