Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized constants file for docker Images in Jenkinsfile #1325

Open
2 tasks
Tracked by #1207
abhinavGupta16 opened this issue Dec 14, 2021 · 3 comments
Open
2 tasks
Tracked by #1207

Centralized constants file for docker Images in Jenkinsfile #1325

abhinavGupta16 opened this issue Dec 14, 2021 · 3 comments
Labels
enhancement New Enhancement

Comments

@abhinavGupta16
Copy link
Contributor

abhinavGupta16 commented Dec 14, 2021

Is your feature request related to a problem? Please describe

Currently, the image file is mentioned as a hardcoded string in every jenkinsfile. Any change or upgrade in the image is difficult since we would have to manually go to every jenkinsfile and edit the docker image.

This Manual process makes it easy to miss a file causing unwanted errors when running jobs such as these - http://jenki-jenki-fpgmrv2ryxko-1366042710.us-east-1.elb.amazonaws.com/job/opensearch-java-maven-sign-and-release/4/console

Describe the solution you'd like

One constants file which contains all the docker images used in every jenkinsfile. This would make it one point change for nay changes in the image. Any new additional image can be easily added to this file.

Acceptance Criteria

  • No jenkinsfile should have the image name hardcoded as a string.
  • All jenkins jobs should work as before

Describe alternatives you've considered

No response

Additional context

No response

@abhinavGupta16 abhinavGupta16 added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Dec 14, 2021
@dblock
Copy link
Member

dblock commented Dec 14, 2021

This makes docker images a moving target implicitly, whereas in the manifests we want something that can be reproduced indefinitely. The ask here is a subset of #1207: one should be able to write ubuntu-latest vs. specific-docker-image in both manifests and other Jenkinsfile(s), thus expressing intent of which image to use clearly.

@zelinh zelinh removed the untriaged Issues that have not yet been triaged label Dec 27, 2021
@zelinh
Copy link
Member

zelinh commented Dec 27, 2021

[Triage] Moving to product backlog, part of issue #1207 and we will discuss how we want to proceed.

@gaiksaya
Copy link
Member

gaiksaya commented Jan 5, 2024

Related #4233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants