-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of hard-coded version in Jenkinsfile(s) in main #7
Comments
I wonder if all the libs can load / preload a common-lib where the Writing a workflow to handle all the version update and send a PR seems like a hack to me. Thanks. |
+1 @peterzhuamazon if the version is located only in 1 place that works too |
There are 2 things:
For 1. The idea here is each file can have it own version that the file needs to be used. For example, we add some library that will only be used by dashboards. Now only dashboards jenkinsFile will use the new version (1.2.0). For 2. In case of libraries used within libraries I believe main sounds good however, since we are using |
New issues coming up after we have a merge of #13 this morning with main and 1.0.0/1.0.1 mismatch which cause jacoco reports generation to fail.
2. Even if you define above if your jenkinsfile is calling another lib from this repo, then the `remote` param in jenkinsfile is not taking effect while the `identifier` is. In my own test I force test file to have official repo while jenkinsfile having my own fork url, turns out:
3. If your jenkinsfile is calling another lib from libs repo in vars, then a suspicious `main` will always be called no matter what. We suspect this is coming from the `main` from all the local definition of `jenkins@main` in this repo for legacyscm, but it doesnt make sense that it is actively closing using gitSource:
Any commitid mismatch would cause jacoco to fail as it is using commitid as part of the identifier. All above 3 issues will cause Jacoco to fail. Thanks. |
Is your feature request related to a problem? Please describe
In #6 we replaced
@date
by@1.0.0
in Jenkinsfile(s). Every time a version is incremented it will require doing that across many files, which is a lot of busy work.Describe the solution you'd like
@main
.Release
workflow that can be triggered by hand by any maintainer.@main
by@version
in that workflow.So, to release current version (it's 1.0.0 now), maintained hits a button. Workflow checks out code, replaces all
@main
by@1.0.0
, creates a branch called1.0.0
, commits the code to that branch, tags it as1.0.0
, creates a GitHub release, increments the version to 1.0.1 on main, commits and pushes everything.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: