Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to list test_executions when there are aggregates with user tags #685

Closed
IanHoang opened this issue Oct 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@IanHoang
Copy link
Collaborator

IanHoang commented Oct 24, 2024

Describe the bug

When I run list test_executions, an error occurs:

$ opensearch-benchmark list test_executions

   ____                  _____                      __       ____                  __                         __
  / __ \____  ___  ____ / ___/___  ____ ___________/ /_     / __ )___  ____  _____/ /_  ____ ___  ____ ______/ /__
 / / / / __ \/ _ \/ __ \\__ \/ _ \/ __ `/ ___/ ___/ __ \   / __  / _ \/ __ \/ ___/ __ \/ __ `__ \/ __ `/ ___/ //_/
/ /_/ / /_/ /  __/ / / /__/ /  __/ /_/ / /  / /__/ / / /  / /_/ /  __/ / / / /__/ / / / / / / / / /_/ / /  / ,<
\____/ .___/\___/_/ /_/____/\___/\__,_/_/   \___/_/ /_/  /_____/\___/_/ /_/\___/_/ /_/_/ /_/ /_/\__,_/_/  /_/|_|
    /_/

[ERROR] Cannot list. 'list' object has no attribute 'items'.

Getting further help:
*********************
* Check the log files in /Users/hoangia/.benchmark/logs for errors.
* Read the documentation at https://opensearch.org/docs.
* Ask a question on the forum at https://forum.opensearch.org/.
* Raise an issue at https://github.com/opensearch-project/OpenSearch-Benchmark/issues and include the log files in /Users/hoangia/.benchmark/logs.

-------------------------------
[INFO] FAILURE (took 0 seconds)
-------------------------------

OSB assumes user-tags in each test execution as a key-value pair source

--user-tag: Defines user-specific key-value pairs to be used in metric record as meta information, for example, intention:baseline-ticket-12345.

This error is occurring because when OSB tries to fetch the user tags for aggregated test executions, it is unable to get the user tags because it's a list.

 "user-tags": [
  "57632daf-5031-45c0-abe4-3d4ac8378c1b",
  "32b6c048-7f74-411f-b6c9-2f6abd271a71",
  "9d4cc35c-501f-49a1-80ea-f195bcee26d9"
 ],

To reproduce

  1. Download latest OSB version (1.10.0). Issue also occurs in 1.9.1 and before.
  2. Run opensearch-benchmark list test_executions

Expected behavior

No response

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

@IanHoang IanHoang added bug Something isn't working untriaged and removed untriaged labels Oct 24, 2024
@IanHoang
Copy link
Collaborator Author

We can easily fix this by adding keys to each ID. Example:

 "user-tags": [
  "tid_1": "57632daf-5031-45c0-abe4-3d4ac8378c1b",
  "tid_2": "32b6c048-7f74-411f-b6c9-2f6abd271a71",
  "tid_3": "9d4cc35c-501f-49a1-80ea-f195bcee26d9"
 ],

@IanHoang
Copy link
Collaborator Author

Synced offline with @OVI3D0. Issue was on my end as I had outdated aggregate feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant