Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC/PROPOSAL] Benchmarking with jemalloc #370

Open
dblock opened this issue Sep 8, 2023 · 2 comments
Open

[RFC/PROPOSAL] Benchmarking with jemalloc #370

dblock opened this issue Sep 8, 2023 · 2 comments
Labels
RFC Request for comment on major changes

Comments

@dblock
Copy link
Member

dblock commented Sep 8, 2023

What/Why

What are you proposing?

In opensearch-project/OpenSearch#9496 we are discussing whether to package or not package jemalloc in the distribution. Either way we want to know the performance benefits of jemalloc with features such as k-nn that use native libraries. The ask is to add jemalloc supports + runs.

What users have asked for this feature?

See opensearch-project/OpenSearch#9496.

What problems are you trying to solve?

Reliably measure the performance improvements of jemalloc so that we can/cannot recommend it.

What is the developer experience going to be?

  1. Documentation of how to enable jemalloc in opensearch-benchmark.
  2. Daily runs with performance metrics.
@gkamat
Copy link
Collaborator

gkamat commented Sep 12, 2023

Use of jemalloc as the preferred allocator is not controlled by OSB, since it is simply a client. This is entirely determined on the OpenSearch side, and the mechanism is to set the LD_PRELOAD environment variable appropriately.

That being said, the capability can be added to the nightly performance runs to configure this in the cluster CDK. This task will be tracked separately.

@rishabh6788
Copy link
Collaborator

rishabh6788 commented Sep 12, 2023

@dblock As long as we get a tar distribution created (-min or bundle) with jemalloc it should be straight forward to start nightly benchmark on them.

From the issue description it seems you want to enable it using OSB, can you please elaborate on this?

One quick way to test this out is to handle this in opensearch-cluster-cdk, add an option to use jemalloc and then handle installation (if not bundled with OpenSearch) and setting env variable.
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for comment on major changes
Projects
None yet
Development

No branches or pull requests

3 participants