Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs view implementation for Visualization #773

Closed
nidhisinghai opened this issue Jun 1, 2022 · 8 comments
Closed

Logs view implementation for Visualization #773

nidhisinghai opened this issue Jun 1, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@nidhisinghai
Copy link
Contributor

nidhisinghai commented Jun 1, 2022

Hello @rinku-kumar-psl

This Issue requires a below Implementation -
Logs view implementation under Visualization and its config options implementation as per issue 697.

@abasatwar @spattnaik

@nidhisinghai nidhisinghai added enhancement New feature or request untriaged labels Jun 1, 2022
@nidhisinghai nidhisinghai changed the title Logview integration for Visulization Logview implementation for Visulization Jun 1, 2022
@nidhisinghai nidhisinghai changed the title Logview implementation for Visulization Logs view implementation for Visualization Jun 1, 2022
@ruchika-narang
Copy link
Contributor

Hey @mengweieric @btzeng

We have started implementation on this ticket and have few queries related to it.

  1. What data should we show in logs visualizations. Eg: If a user queries with multiple fields, then do we have to show the raw response with all the fields or the filtered response with field specified by users.
  2. If filtered PPL response doesn't have any field of timestamp, do we have to disable the time from config panel or we pick up the timestamp from raw data received?
  3. We see unique labels and common labels in the config panel. What are these keys in the response data?
  4. In config panel, under the title Deduplication, we have options as (None, exact, numbers, signature). Could you please let us know what do these options signify.
  5. Also do we have to show the log view visualization for every query?
  6. When we open the accordion, we see an ad-hoc statistics icon beside every field in the accordion, do we have to implement that too?

Thanks,
Ruchika
CC: @anirudha @abasatwar @spattnaik

@mengweieric
Copy link
Collaborator

Hi @ruchika-narang,

What we should have for log config panel would be

Panel options

  • title
  • descriptions

Logs

Time (switch)
Show or hide the time column. This is the timestamp associated with the log line as reported from the data source. Disabled if index does not contain timestamp

Font size (number only input)
Changes the size of the log font

Order (filter buttons)
Time asc / desc

  1. We reuses the log view from event tab.
  2. Yes, we should disable any timestamp related config option.
  3. Could share a little more about what do you mean for every query?

For 2,3,4 and 6, for now we just need above config items to be implemented. I'll share the doc with more details for this part once we finished doc review and iterations.

@shankha-das
Copy link
Contributor

Hi @mengweieric , @btzeng,

We have implemented these config options in Logs View:

  1. Time
  2. Wrap lines
  3. Prettify JSON
  4. Enable log details
  5. Order
  6. Label Size

We have also disabled Time Switch if no timestamp is available in the data. As we are still waiting for updated documents or requirements for Deduplication, Unique Label, and Common Label from your side, So these 3 features are not implemented as per now.

CC @abastwar, @spattnaik, @rinku-kumar-psl.

@shankha-das
Copy link
Contributor

Hi @mengweieric , @btzeng
Please refer attached video for implementation we have done

logs_view_implementation.mp4

Please share your inputs

Thanks

@pratibhapandey16
Copy link
Contributor

pratibhapandey16 commented Jul 11, 2022

Hi @shankha-das,
Please find the below observations.

  1. On clicking reset button the Label size value is not changing to blank.
  2. Details are not getting updated accordingly when we select negative value for the Label Size.

@pratibhapandey16
Copy link
Contributor

Hi @mengweieric , @btzeng

Could you please confirm if we need Data Configurations section for Logs view?

Regards,
Pratibha
CC @abasatwar, @spattnaik.

@shankha-das
Copy link
Contributor

Hi @btzeng ,

As discussed in the Demo call, we had concluded to not let user select Prettify JSON when Wrap Lines is enabled. As default, wrap lines and prettify JSON views are completely different and not related to each other, I have combined them to show as a button group of these three options from which the user can select one and it is more user friendly. Following is the screenshot of the implementation, let me know if this looks good to you and I can proceed with this.

MicrosoftTeams-image (12)

cc: @anirudha @mengweieric @spattnaik @abasatwar

@pratibhapandey16
Copy link
Contributor

Completed functional testing for Logs view issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants