-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs view implementation for Visualization #773
Comments
Hey @mengweieric @btzeng We have started implementation on this ticket and have few queries related to it.
Thanks, |
Hi @ruchika-narang, What we should have for log config panel would be Panel options
Logs Time (switch) Font size (number only input) Order (filter buttons)
For 2,3,4 and 6, for now we just need above config items to be implemented. I'll share the doc with more details for this part once we finished doc review and iterations. |
Hi @mengweieric , @btzeng, We have implemented these config options in Logs View:
We have also disabled Time Switch if no timestamp is available in the data. As we are still waiting for updated documents or requirements for Deduplication, Unique Label, and Common Label from your side, So these 3 features are not implemented as per now. CC @abastwar, @spattnaik, @rinku-kumar-psl. |
Hi @mengweieric , @btzeng logs_view_implementation.mp4Please share your inputs Thanks |
Hi @shankha-das,
|
Hi @mengweieric , @btzeng Could you please confirm if we need Data Configurations section for Logs view? Regards, |
Hi @btzeng , As discussed in the Demo call, we had concluded to not let user select Prettify JSON when Wrap Lines is enabled. As default, wrap lines and prettify JSON views are completely different and not related to each other, I have combined them to show as a button group of these three options from which the user can select one and it is more user friendly. Following is the screenshot of the implementation, let me know if this looks good to you and I can proceed with this. |
Completed functional testing for Logs view issue. |
Hello @rinku-kumar-psl
This Issue requires a below Implementation -
Logs view implementation under Visualization and its config options implementation as per issue 697.
@abasatwar @spattnaik
The text was updated successfully, but these errors were encountered: