Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candlestick chart support in event analytics #644

Closed
2 tasks
pratibhapandey16 opened this issue Apr 12, 2022 · 4 comments · Fixed by #690
Closed
2 tasks

Candlestick chart support in event analytics #644

pratibhapandey16 opened this issue Apr 12, 2022 · 4 comments · Fixed by #690
Labels
enhancement New feature or request

Comments

@pratibhapandey16
Copy link
Contributor

pratibhapandey16 commented Apr 12, 2022

  1. Add Candlestick chart as a dropdown option. Refer dropdown element on top right corner of image.
  2. On selection of it, it should render a Candlestick chart based on data selected.
  3. If data does not have timestamp information , show no record found message.

Capture

This issue contains the below tasks.

  • Adding Candlestick chart to the dropdown on the UI
  • Cypress testing(Automation)
@pratibhapandey16 pratibhapandey16 added the enhancement New feature or request label Apr 12, 2022
@mrunal-z
Copy link
Contributor

Hey @mengweieric @anirudha - In one of our standups, we had decided to remove the candlestick chart and all its code from the repo, but I can see it listed in the chart types table in opensearch-project/dashboards-observability#78. Is it still an upcoming visualization or are we sure we want to remove it?
Thanks!
@abasatwar @spattnaik @pratibhapandey16

@mrunal-z
Copy link
Contributor

Hi @anirudha @mengweieric - As per the discussion in yesterday's standup call, I have removed all the existing code for candlestick chart and have raised the PR.
Thanks!
@abasatwar @spattnaik

@anirudha
Copy link
Collaborator

can we add a demo/video when we have a workflow for this chart

@mengweieric mengweieric linked a pull request Apr 29, 2022 that will close this issue
1 task
@mengweieric
Copy link
Collaborator

@anirudha as per our last conversation candlestick was removed since it makes no sense under Observability context. The code changes have been merged already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants