Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable detekt when snakeyaml vulnerability is fixed #529

Closed
lezzago opened this issue Sep 7, 2022 · 3 comments · Fixed by Noir01/notifications#1 or #796
Closed

Re-enable detekt when snakeyaml vulnerability is fixed #529

lezzago opened this issue Sep 7, 2022 · 3 comments · Fixed by Noir01/notifications#1 or #796
Assignees
@Noir01
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lezzago
Copy link
Member

lezzago commented Sep 7, 2022

Is your feature request related to a problem?
All of the snakeyaml versions are currently vulnerable. detekt depends on snakeyaml.
So, detekt is disabled for now until snakeyaml vulnerability is fixed. #528

this issue is created to track the progress of re-enabling detekt when snakeyaml vulnerability is fixed.
@lezzago lezzago added the enhancement New feature or request label Sep 7, 2022
@lezzago lezzago mentioned this issue Sep 7, 2022
Merged
1 task
@Hailong-am Hailong-am added the good first issue Good for newcomers label Sep 6, 2023
@SuZhou-Joe
Copy link
Member

Add more detail.

@Hailong-am
Copy link
Collaborator

we need bump io.gitlab.arturbosch.detekt:detekt-gradle-plugin version to 1.23.0 based on compatibility matrix of detekt https://detekt.dev/docs/introduction/compatibility/

@Noir01
Copy link
Contributor

Noir01 commented Oct 16, 2023

All that needs to be done is undo the changes of #528 while bumping the version to 1.23.0, right?

Can I be assigned to this?

This was referenced Oct 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Noir01 Noir01

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable detekt Noir01/notifications
Re-enable detekt Noir01/notifications
4 participants
@lezzago @SuZhou-Joe @Noir01 @Hailong-am