From e8f7327e3d0172dd405e27d0323b42e3806d8919 Mon Sep 17 00:00:00 2001 From: Sarat Vemulapalli Date: Mon, 18 Sep 2023 12:20:26 -0700 Subject: [PATCH 1/7] Adding Windows 2019 CI workflow Signed-off-by: Sarat Vemulapalli --- .github/workflows/CI-workflow.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index 352d87ed74..270956efa8 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -120,7 +120,10 @@ jobs: name: Build and Test MLCommons Plugin on Windows if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env - runs-on: windows-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [windows-latest, windows-2019] steps: - name: Setup Java ${{ matrix.java }} From 472550be765efb7390a3c327ede5640c079d202f Mon Sep 17 00:00:00 2001 From: Sarat Vemulapalli Date: Mon, 18 Sep 2023 12:22:26 -0700 Subject: [PATCH 2/7] Enabling CI on personal fork Signed-off-by: Sarat Vemulapalli --- .github/workflows/CI-workflow.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index 270956efa8..69dee25dc3 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -20,7 +20,7 @@ jobs: java: [11, 17] name: Build and Test MLCommons Plugin - if: github.repository == 'opensearch-project/ml-commons' + #if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env runs-on: ubuntu-latest @@ -118,7 +118,7 @@ jobs: matrix: java: [11, 17] name: Build and Test MLCommons Plugin on Windows - if: github.repository == 'opensearch-project/ml-commons' + #if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env runs-on: ${{ matrix.os }} strategy: From d874bdcbb66ee0e3b12e01cf8529ca50cbf595c3 Mon Sep 17 00:00:00 2001 From: Sarat Vemulapalli Date: Mon, 18 Sep 2023 12:29:59 -0700 Subject: [PATCH 3/7] Removing pull request target Signed-off-by: Sarat Vemulapalli --- .github/workflows/CI-workflow.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index 69dee25dc3..4f61fbc979 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -6,8 +6,8 @@ on: - 'backport/**' - 'create-pull-request/**' - 'dependabot/**' - pull_request_target: - types: [opened, synchronize, reopened] + #pull_request_target: + #types: [opened, synchronize, reopened] permissions: id-token: write From e88004577cc0d6057579d1109d784109fe5ef8b0 Mon Sep 17 00:00:00 2001 From: Sarat Vemulapalli Date: Mon, 18 Sep 2023 12:32:17 -0700 Subject: [PATCH 4/7] Uncomment changes Signed-off-by: Sarat Vemulapalli --- .github/workflows/CI-workflow.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index 4f61fbc979..270956efa8 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -6,8 +6,8 @@ on: - 'backport/**' - 'create-pull-request/**' - 'dependabot/**' - #pull_request_target: - #types: [opened, synchronize, reopened] + pull_request_target: + types: [opened, synchronize, reopened] permissions: id-token: write @@ -20,7 +20,7 @@ jobs: java: [11, 17] name: Build and Test MLCommons Plugin - #if: github.repository == 'opensearch-project/ml-commons' + if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env runs-on: ubuntu-latest @@ -118,7 +118,7 @@ jobs: matrix: java: [11, 17] name: Build and Test MLCommons Plugin on Windows - #if: github.repository == 'opensearch-project/ml-commons' + if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env runs-on: ${{ matrix.os }} strategy: From f7d18d3bff67d1b4c54c60dbb765b722daf40b92 Mon Sep 17 00:00:00 2001 From: Sarat Vemulapalli Date: Mon, 18 Sep 2023 12:50:18 -0700 Subject: [PATCH 5/7] Reorder Windows runners Signed-off-by: Sarat Vemulapalli --- .github/workflows/CI-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index 270956efa8..49391046b5 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -123,7 +123,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [windows-latest, windows-2019] + os: [windows-2019, windows-latest] steps: - name: Setup Java ${{ matrix.java }} From 426f8077d8eb792573c0be61a4fb494ae615b411 Mon Sep 17 00:00:00 2001 From: Sarat Vemulapalli Date: Mon, 18 Sep 2023 13:02:35 -0700 Subject: [PATCH 6/7] Commenting matrix Signed-off-by: Sarat Vemulapalli --- .github/workflows/CI-workflow.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index 49391046b5..c1ad54a60e 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -120,10 +120,10 @@ jobs: name: Build and Test MLCommons Plugin on Windows if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env - runs-on: ${{ matrix.os }} - strategy: - matrix: - os: [windows-2019, windows-latest] + runs-on: windows-2019 + #strategy: + # matrix: + # os: [windows-2019, windows-latest] steps: - name: Setup Java ${{ matrix.java }} From 6f3db013238227df081c7ca1d61530f12600c224 Mon Sep 17 00:00:00 2001 From: Sarat Vemulapalli Date: Mon, 18 Sep 2023 13:49:26 -0700 Subject: [PATCH 7/7] Fixing OS runners Signed-off-by: Sarat Vemulapalli --- .github/workflows/CI-workflow.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index c1ad54a60e..28f12fbaf7 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -117,13 +117,11 @@ jobs: strategy: matrix: java: [11, 17] + os: [windows-2019, windows-latest] name: Build and Test MLCommons Plugin on Windows if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env - runs-on: windows-2019 - #strategy: - # matrix: - # os: [windows-2019, windows-latest] + runs-on: ${{ matrix.os }} steps: - name: Setup Java ${{ matrix.java }}