Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Get conversation meta don't return application_type #2632

Closed
Hailong-am opened this issue Jul 10, 2024 · 2 comments
Closed

[BUG] Get conversation meta don't return application_type #2632

Hailong-am opened this issue Jul 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Hailong-am
Copy link
Contributor

Is your feature request related to a problem?

current get memory api https://opensearch.org/docs/latest/ml-commons-plugin/api/memory-apis/get-memory/ will return response like below, it miss application_type field.

{
  "memory_id": "gW8Aa40BfUsSoeNTvOKI",
  "create_time": "2024-02-02T18:07:06.887061463Z",
  "updated_time": "2024-02-02T19:01:32.121444968Z",
  "name": "Conversation for a RAG pipeline",
  "user": "admin"
}

mapping of system index .plugins-ml-memory-meta

{
  ".plugins-ml-memory-meta": {
    "mappings": {
      "_meta": {
        "schema_version": 1
      },
      "properties": {
        "application_type": {
          "type": "keyword"
        },
        "create_time": {
          "type": "date",
          "format": "strict_date_time||epoch_millis"
        },
        "name": {
          "type": "text"
        },
        "updated_time": {
          "type": "date",
          "format": "strict_date_time||epoch_millis"
        },
        "user": {
          "type": "keyword"
        }
      }
    }
  }
}

What solution would you like?
A clear and concise description of what you want to happen.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@Hailong-am Hailong-am added enhancement New feature or request untriaged labels Jul 10, 2024
@Hailong-am
Copy link
Contributor Author

Hailong-am commented Jul 10, 2024

@Zhangxunmt As you add the application_type field in this PR https://github.com/opensearch-project/ml-commons/pull/1730/files/c1e8e2fb772cb38f3de9598b0606494eb1c3f236#diff-c99fc312519dcb3fa952ea768ddcd6139fa9349669c111c186270e2869b98fdf.

Want to confirm with you does this application_type not return by intention? is there a specific reason or we just miss it?

@Hailong-am Hailong-am changed the title [FEATURE] Get conversation meta return application_type [BUG] Get conversation meta don't return application_type Jul 10, 2024
@b4sjoo b4sjoo moved this to Untriaged in ml-commons projects Jul 16, 2024
@b4sjoo b4sjoo removed the untriaged label Jul 16, 2024
@b4sjoo b4sjoo moved this from Untriaged to In Progress in ml-commons projects Jul 16, 2024
@Zhangxunmt
Copy link
Collaborator

This is expected. Not a bug. Already discussed this issue in other threads.

@github-project-automation github-project-automation bot moved this from In Progress to Done in ml-commons projects Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants