Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Benchmarking] Allow number of vectors to not be divisible by number of clients #426

Closed
jmazanec15 opened this issue Jun 21, 2022 · 1 comment
Closed

[Benchmarking] Allow number of vectors to not be divisible by number of clients #426

jmazanec15 opened this issue Jun 21, 2022 · 1 comment
Labels
good first issue Good for newcomers Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@jmazanec15
Copy link
Member

Related to #409 (comment).

Currently, OSB benchmark workload can only use multiple clients when the data set can be partitioned evenly. For example, for a data set with 100 vectors, 10 clients could be used but not 9 (ref).

Instead of requiring the number of vectors to be divisible by the number of clients, we could have one client execute fewer requests.
@jmazanec15 jmazanec15 added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jun 21, 2022
@navneet1v navneet1v added the good first issue Good for newcomers label Sep 15, 2023
@jmazanec15
Copy link
Member Author

Closing as this was added in OSB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@navneet1v @jmazanec15