Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GPL 2.0 License #2291

Closed
perleino opened this issue Nov 27, 2024 · 4 comments
Closed

[BUG] GPL 2.0 License #2291

perleino opened this issue Nov 27, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@perleino
Copy link

perleino commented Nov 27, 2024

What is the bug?
As i understand Opensearch is under Apache 2.0 license. How ever it looks like K-NN is using https://github.com/opensearch-project/k-NN/blob/main/micro-benchmarks/build.gradle#L30 jmh-core that is under GPL 2.0 license: https://github.com/openjdk/jmh/blob/master/LICENSE is this OK from a license perspective ? Should the https://github.com/opensearch-project/k-NN/blob/main/micro-benchmarks be marked as GPL 2.0 ?

How can one reproduce the bug?
N/A

What is the expected behavior?
N/A

What is your host/environment?
N/A

Do you have any screenshots?
N/A

Do you have any additional context?

@perleino perleino added bug Something isn't working untriaged labels Nov 27, 2024
@navneet1v
Copy link
Collaborator

@perleino this could have been added by mistake. This package was inspired from: https://github.com/opensearch-project/OpenSearch/blob/main/benchmarks/build.gradle#L54 If jmh is not Apache license, we can remove this module.

@dblock dblock removed the untriaged label Dec 16, 2024
@dblock
Copy link
Member

dblock commented Dec 16, 2024

@navneet1v @vamshin Can someone pick this one up please ASAP?

[Catch All Triage - 1, 2, 3]

@navneet1v
Copy link
Collaborator

navneet1v commented Dec 16, 2024

Will raise a PR today to remove the module. and later I will see how we can fix it. I see Lucene is also using the same. Let me see how they have implemented this and get away from this GPL thing.
Ref: https://github.com/apache/lucene/tree/main/lucene/benchmark-jmh and I see this too: https://github.com/apache/lucene/blob/main/lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/Main.java#L25 so I am little confused why this is a problem with k-NN plugin.

Also, this module is not shipped with Opensearch distribution.

@navneet1v
Copy link
Collaborator

Resolving the GH issue. Since the module is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants