Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #220

Closed
3 tasks done
dblock opened this issue Nov 17, 2021 · 9 comments
Closed
3 tasks done

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #220

dblock opened this issue Nov 17, 2021 · 9 comments
Labels
untriaged v1.3.0 Issues and PRs related to version 1.3.0

Comments

@dblock
Copy link
Member

dblock commented Nov 17, 2021

Coming from opensearch-project/opensearch-plugins#64, default CI Java version to 11 (LTS), and run tests on 8, 14 and 17.

  • Change the default Java version for CI in GitHub actions from 14/15 to 11 (LTS).
  • Add Java 8, 14 (used before), and 17 (next LTS) to the CI matrix.
  • Document Java versions in DEVELOPER_GUIDE.md.
@martin-gaievski
Copy link
Member

Added JDK 11 and set it as a default version in DEVELOPER_GUIDE.md.

For JDK 8 and JDK 17 there are some issues and we don't solution yet. For JDK 8 it's OS, seems it has been compiled with JDK 9:

org/opensearch/gradle/plugin/PluginPropertiesExtension has been compiled by a more recent version of the Java Runtime (class file version 54.0), this version of the Java Runtime only recognizes class file versions up to 52.0
https://github.com/martin-gaievski/k-NN/runs/4945583353?check_suite_focus=true

for JDK 17 higher gradle version is required, I've tested with 7.3.3. It fails with

Error: Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/cli/CommandLineParser
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:43)
https://github.com/opensearch-project/k-NN/runs/4957612326?check_suite_focus=true
I've tried multiple things locally - different gradle versions, generating new gradle wrapper, setting java language level for tooling etc., but no success.

@martin-gaievski
Copy link
Member

There is a related issue for OpenSearch in relation to JDK 8 and 17 Remove support for Java 8, add support for Java 17. KNN is blocked until that issue is addressed by the OpenSearch team.

@martin-gaievski
Copy link
Member

Merged #2025 to address JDK 8 and JDK 17 requirements. Change is for OpenSearch 2.0 release, and not going to be ported to 1.x. As k-NN follows OpenSearch release path/versions, this means build issues for k-NN 1.x still remain unresolved. Suggesting to close this issue or move it to 2.0 release.

@dblock
Copy link
Member Author

dblock commented Feb 8, 2022

@martin-gaievski Care to pitch in a comment for opensearch-project/opensearch-plugins#110 (comment) pls?

@reta
Copy link
Contributor

reta commented Feb 8, 2022

@martin-gaievski for 2.0.0, the upgrade to Gradle 7.x is required, I could submit the PR for k-NN, wdyt?

@martin-gaievski
Copy link
Member

@reta sure Andriy, we haven't released knn 1.3 yet, so current main is gonna be used for this. Let me discuss with the team if we can cut off 1.3 release branch soon, if so I'll put an update here and you can continue with PR.

@reta
Copy link
Contributor

reta commented Feb 8, 2022

Thanks @martin-gaievski ! Sure, please take you time!

@martin-gaievski
Copy link
Member

@reta please go ahead with the PR. For knn we have created branch 1.x that will serve for any 1.x releases, so main is good to go for 2.x changes.

@martin-gaievski
Copy link
Member

Solve all issues related to 1.3 knn release, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged v1.3.0 Issues and PRs related to version 1.3.0
Projects
None yet
Development

No branches or pull requests

3 participants