-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default CI Java Version to Java 11, run tests on 8, 14 and 17 #220
Comments
Added JDK 11 and set it as a default version in DEVELOPER_GUIDE.md. For JDK 8 and JDK 17 there are some issues and we don't solution yet. For JDK 8 it's OS, seems it has been compiled with JDK 9: org/opensearch/gradle/plugin/PluginPropertiesExtension has been compiled by a more recent version of the Java Runtime (class file version 54.0), this version of the Java Runtime only recognizes class file versions up to 52.0 for JDK 17 higher gradle version is required, I've tested with 7.3.3. It fails with Error: Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/cli/CommandLineParser |
There is a related issue for OpenSearch in relation to JDK 8 and 17 Remove support for Java 8, add support for Java 17. KNN is blocked until that issue is addressed by the OpenSearch team. |
Merged #2025 to address JDK 8 and JDK 17 requirements. Change is for OpenSearch 2.0 release, and not going to be ported to 1.x. As k-NN follows OpenSearch release path/versions, this means build issues for k-NN 1.x still remain unresolved. Suggesting to close this issue or move it to 2.0 release. |
@martin-gaievski Care to pitch in a comment for opensearch-project/opensearch-plugins#110 (comment) pls? |
@martin-gaievski for 2.0.0, the upgrade to Gradle 7.x is required, I could submit the PR for |
@reta sure Andriy, we haven't released knn 1.3 yet, so current main is gonna be used for this. Let me discuss with the team if we can cut off 1.3 release branch soon, if so I'll put an update here and you can continue with PR. |
Thanks @martin-gaievski ! Sure, please take you time! |
Solve all issues related to 1.3 knn release, closing this one |
Coming from opensearch-project/opensearch-plugins#64, default CI Java version to 11 (LTS), and run tests on 8, 14 and 17.
The text was updated successfully, but these errors were encountered: