Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default vector engine from nmslib to faiss #2163

Closed
vamshin opened this issue Sep 27, 2024 · 6 comments
Closed

Switch default vector engine from nmslib to faiss #2163

vamshin opened this issue Sep 27, 2024 · 6 comments
Assignees

Comments

@vamshin
Copy link
Member

vamshin commented Sep 27, 2024

Is your feature request related to a problem?
The nmslib vector engine is currently in maintenance mode as of 10/27, and we plan to deprecate it in the 3.x version. All the feature development/optimizations are focused in faiss engine since 2.7 version. To align the new vector indexes with these improvements, it would be beneficial to switch the default vector engine from nmslib to faiss.

What solution would you like?
Switch the default vector engine from nmslib to faiss.

@vamshin vamshin changed the title [FEATURE] Switch default engine from nmslib to faiss [FEATURE] Switch default vector engine from nmslib to faiss Sep 27, 2024
@vamshin vamshin added v2.18.0 Roadmap:Vector Database/GenAI Project-wide roadmap label and removed untriaged labels Sep 27, 2024
@vamshin vamshin moved this from Backlog to 2.18.0 in Vector Search RoadMap Sep 27, 2024
@vamshin vamshin changed the title [FEATURE] Switch default vector engine from nmslib to faiss Switch default vector engine from nmslib to faiss Sep 27, 2024
@navneet1v
Copy link
Collaborator

@vamshin I see this issue is put in 2.18 version? is the feature planned for 2.18?

@vamshin
Copy link
Member Author

vamshin commented Oct 2, 2024

@navneet1v yes, idea is to do for 2.18

@vamshin
Copy link
Member Author

vamshin commented Oct 7, 2024

As part of this default switch to faiss, I feel we should also switch to fp_16 with in faiss.

@jmazanec15
Copy link
Member

I think that until we can automatically handle cases where the data may not fit inside fp_16, we should not do this yet. Instead, for OOTB experience, users can specify compression and/or mode. If needed, we can introduce a new mode or similar meta parameter.

@vamshin
Copy link
Member Author

vamshin commented Oct 31, 2024

For 2.18, we can just make faiss default and later figure out plan for making fp_16 as default.

@github-project-automation github-project-automation bot moved this from 2.18.0 to ✅ Done in Vector Search RoadMap Nov 6, 2024
@navneet1v navneet1v reopened this Nov 7, 2024
@navneet1v navneet1v moved this from ✅ Done to 2.19.0 in Vector Search RoadMap Nov 7, 2024
@dblock
Copy link
Member

dblock commented Nov 11, 2024

[Catch All Triage - 1, 2, 3, 4]

@dblock dblock removed the untriaged label Nov 11, 2024
@github-project-automation github-project-automation bot moved this from 2.19.0 to ✅ Done in Vector Search RoadMap Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Status: Done
Development

No branches or pull requests

5 participants