Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor k-NN parsing in a common place to be able to be reused in Neural plugin #1756

Open
shatejas opened this issue Jun 13, 2024 · 0 comments

Comments

@shatejas
Copy link
Collaborator

shatejas commented Jun 13, 2024

Is your feature request related to a problem?
Currently adding parameters in K-NN requires changes in Neural. There is a chance of inconsistencies there with this duplication and increases the dev work of making changes.

What solution would you like?
Since opensearch neural plugin takes a direct dependency on k-NN. I would like to see neural getting access to new parameters without code changes

What alternatives have you considered?
Alternative is to maintain the status quo and keep duplicating parameters in query builders

Do you have any additional context?
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants