Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support switch alias from source to target index in shrink action #676

Closed
bowenlan-amzn opened this issue Jan 30, 2023 · 6 comments
Assignees
Labels
enhancement New request good first issue Good for newcomers ism action small v2.12.0 Issues targeting release v2.12.0

Comments

@bowenlan-amzn
Copy link
Member

Support switch alias from source to target index in shrink action

@bowenlan-amzn bowenlan-amzn added the enhancement New request label Jan 30, 2023
@Jakob3xD
Copy link

Would be really nice to see this.
I currently have two polices that shrink indices before they get moved to cold nodes and loosing the read alias when shrink them is a real pain, as I now have to copy my polices for each index and use the alias action to apply the read alias again.

@ikibo
Copy link
Contributor

ikibo commented Oct 3, 2023

@bowenlan-amzn could I be assigned to this issue plz? THNX!

@ikibo
Copy link
Contributor

ikibo commented Oct 3, 2023

A point to take into account :
When shrinking an index, there are two sources of aliases for the target-index:

  • aliases from the shrink action in the policy
  • aliases from the source index

Index alias is unique by name, and names of aliases may coincide in these two sources. In such a case, there is a collision, and priority will be given to the alias from the policy. Hence the target-index will possess an alias from the policy.

this is a natural decision, in such a way a client may override some properties of a source-index alias, and of course, add new aliases on demand.
if we follow this approach, we need to add this to the official doc for the correct release version, so that clients are aware, and are protected from undesired error/behaviour.

@bowenlan-amzn plz sign off if the above is good.

@bowenlan-amzn
Copy link
Member Author

Yes, this idea looks good.
Doc is needed for this, and would you please add a new param switch_alias in shrink action and default to false. Thanks!

@hdhalter
Copy link

hdhalter commented Nov 6, 2023

@bowenlan-amzn - can you please add this to the roadmap/tracker for 2.12? Thanks!

@bowenlan-amzn
Copy link
Member Author

@hdhalter added to the unified project tracker, pls lemme know if it's not right way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New request good first issue Good for newcomers ism action small v2.12.0 Issues targeting release v2.12.0
Projects
Status: Done
Development

No branches or pull requests

4 participants