Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Separate RegisterModelStep into RegsiterRemoteModelStep and RegisterLocalModelStep #149

Closed
joshpalis opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@joshpalis
Copy link
Member

joshpalis commented Nov 7, 2023

Is your feature request related to a problem?

Currently our RegisterModelStep is attempting to parse fields for both registering a local model and registering a remote model (link). In order to identify optional fields and enforce required fields, it is necessary to separate the step into RegisterLocalModelStep and RegisterRemoteModelStep

What solution would you like?

The RegisterLocalModelStep should have the following required fields (API Documentation):

  • name
  • version
  • model_format
  • model_group_id
  • model_content_hash_value
  • model_config
  • url

The model_config field is a JSON object which includes the following fields :

  • model_type - required
  • embedding_dimension - required
  • framework_type - required
  • all_config - optional field that contains all model configurations

The RegisterRemoteModelStep should have the following fields (API Documentation)

  • name
  • function_name
  • model_group_id
  • description
  • connector_id OR connector

The connector_id field is just a string which is provided by the create connector API. However, there is an option to define an inline connector configuration (internal connector API documentation), which contain all the required Create Connector API fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant