Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added api info for reloadcerts #753

Merged
merged 1 commit into from
Jul 5, 2022
Merged

added api info for reloadcerts #753

merged 1 commit into from
Jul 5, 2022

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Jul 1, 2022

Fixes #530

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum cwillum requested a review from a team as a code owner July 1, 2022 22:07
hdhalter
hdhalter approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Chris! You might want to link to the previous pull request where there were some comments and approvals from both dev and doc.

@cwillum
Copy link
Contributor Author

cwillum commented Jul 2, 2022

@hdhalter Good recommendation. The previous pull request is #744. This current pull request was created to work around DCO errors in the original.

@cwillum cwillum merged commit d4738c7 into main Jul 5, 2022
@Naarcha-AWS Naarcha-AWS added the backport 2.0 PR: Backport label for v2.0.x label Jul 5, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 5, 2022
@cwillum @github-actions
added api info for reloadcerts (#753)
9a1d3a7 
Signed-off-by: cwillum <[email protected]>
(cherry picked from commit d4738c7)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 5, 2022
Merged
Naarcha-AWS pushed a commit that referenced this pull request Jul 5, 2022
@opensearch-trigger-bot @cwillum
added api info for reloadcerts (#753) (#759)
460629a 
Signed-off-by: cwillum <[email protected]>
(cherry picked from commit d4738c7)

Co-authored-by: cwillum <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the FixFor#530 branch July 28, 2022 23:15
@cwillum cwillum mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdhalter hdhalter hdhalter approved these changes

@lizsnyder lizsnyder lizsnyder approved these changes

Assignees
No one assigned
Labels
backport 2.0 PR: Backport label for v2.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Missing documentation for security plugin reloadcerts endpoints
4 participants
@cwillum @lizsnyder @hdhalter @Naarcha-AWS