Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted the changes from PR #558 #747

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

JeffHuss
Copy link

@JeffHuss JeffHuss commented Jul 1, 2022

Fixes #741

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@JeffHuss JeffHuss requested a review from a team as a code owner July 1, 2022 15:18
@JeffHuss JeffHuss added v2.0.0 3 - Tech review PR: Tech review in progress backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x labels Jul 1, 2022
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeffHuss JeffHuss merged commit ff4a818 into main Jul 1, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 1, 2022
Signed-off-by: jeffhuss <[email protected]>
(cherry picked from commit ff4a818)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 1, 2022
Signed-off-by: jeffhuss <[email protected]>
(cherry picked from commit ff4a818)
@JeffHuss JeffHuss removed the backport 1.3 PR: Backport label for v1.3.x label Jul 1, 2022
@@ -12,14 +12,7 @@ redirect_from:

Historically, many multiple popular agents and ingestion tools have worked with Elasticsearch OSS, such as Beats, Logstash, Fluentd, FluentBit, and OpenTelemetry. OpenSearch aims to continue to support a broad set of agents and ingestion tools, but not all have been tested or have explicitly added OpenSearch compatibility.

Previously, an intermediate compatibility solution was available. OpenSearch had a setting that instructed the cluster to return version 7.10.2 rather than its actual version.

The override main response setting `compatibility.override_main_response_version` is deprecated from OpenSearch version 1.x and removed from OpenSearch 2.0.0. This setting is no longer supported for compatibility with legacy clients.
Copy link
Member

@dreamer-89 dreamer-89 Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2.0.0 doesn't support compatibility.override_main_response_version setting. In that case, we can keep it like this and add a note that override_main_response_version was added back in 2.0.1 for external client compatibility ?

@nknize @reta : WDYT ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreamer-89: Wasn't it reverted back into 2.0 here? opensearch-project/OpenSearch#3530 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setting was removed in 2.0 but it broke external client integrations such as beats etc. In order to fix it, the setting was added back in 2.0.1 which allowed clients to spoof OpenSearch engine again in 2.0.1 to 7.10.

@Naarcha-AWS Naarcha-AWS deleted the add-override-setting-back-issue-741 branch July 1, 2022 20:29
Naarcha-AWS pushed a commit that referenced this pull request Jul 1, 2022
Signed-off-by: jeffhuss <[email protected]>
(cherry picked from commit ff4a818)

Co-authored-by: Jeff Huss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Tech review PR: Tech review in progress backport 2.0 PR: Backport label for v2.0.x v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add override setting back to 2.0
4 participants