-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverted the changes from PR #558 #747
Conversation
Signed-off-by: jeffhuss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: jeffhuss <[email protected]> (cherry picked from commit ff4a818)
Signed-off-by: jeffhuss <[email protected]> (cherry picked from commit ff4a818)
@@ -12,14 +12,7 @@ redirect_from: | |||
|
|||
Historically, many multiple popular agents and ingestion tools have worked with Elasticsearch OSS, such as Beats, Logstash, Fluentd, FluentBit, and OpenTelemetry. OpenSearch aims to continue to support a broad set of agents and ingestion tools, but not all have been tested or have explicitly added OpenSearch compatibility. | |||
|
|||
Previously, an intermediate compatibility solution was available. OpenSearch had a setting that instructed the cluster to return version 7.10.2 rather than its actual version. | |||
|
|||
The override main response setting `compatibility.override_main_response_version` is deprecated from OpenSearch version 1.x and removed from OpenSearch 2.0.0. This setting is no longer supported for compatibility with legacy clients. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreamer-89: Wasn't it reverted back into 2.0 here? opensearch-project/OpenSearch#3530 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setting was removed in 2.0 but it broke external client integrations such as beats etc. In order to fix it, the setting was added back in 2.0.1
which allowed clients to spoof OpenSearch engine again in 2.0.1 to 7.10
.
Signed-off-by: jeffhuss <[email protected]> (cherry picked from commit ff4a818) Co-authored-by: Jeff Huss <[email protected]>
Fixes #741
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.