-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created documentation for security plugin reloadcerts endpoints #744
Conversation
git commit -s -m “fixed#530 Signed-off-by: Moore <[email protected]>
@peternied Please review, Peter. Also, please let me know if this applies to 1.3 and 2.0. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cwillum Looks good to me, I've cross referenced what you've written here with the code and it looks right on point 👍
Yes this document applies to OpenSearch 1.0+ versions (So it should be included in 1.3 and 2.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small suggestions, otherwise LGTM.
Introduced 1.0 | ||
{: .label .label-purple } | ||
|
||
Rest API action to reload SSL certificates. It can be used to reload SSL certificates that are about to expire without restarting OpenSearch node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's follow the format of the other APIs in the file.
Rest API action to reload SSL certificates. It can be used to reload SSL certificates that are about to expire without restarting OpenSearch node. | |
Reloads SSL certificates that are about to expire without restarting the OpenSearch node. |
Co-authored-by: Naarcha-AWS <[email protected]>
#742) Signed-off-by: jeffhuss <[email protected]> Signed-off-by: Moore <[email protected]>
git commit -s -m “fixed#530 Signed-off-by: Moore <[email protected]>
Signed-off-by: Moore <[email protected]>
Closing this PR because I ran into several DCO errors that I couldn't resolve. Opening a new PR in its place. |
Signed-off-by: Moore [email protected]
Issues Resolved
#530
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.