Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created documentation for security plugin reloadcerts endpoints #744

Closed
wants to merge 5 commits into from

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Jun 30, 2022

Signed-off-by: Moore [email protected]

Issues Resolved

#530

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

git commit -s -m “fixed#530

Signed-off-by: Moore <[email protected]>
@cwillum cwillum requested a review from a team as a code owner June 30, 2022 20:37
@cwillum cwillum added the 3 - Tech review PR: Tech review in progress label Jun 30, 2022
@cwillum
Copy link
Contributor Author

cwillum commented Jun 30, 2022

@peternied Please review, Peter. Also, please let me know if this applies to 1.3 and 2.0. Thanks.

@cwillum cwillum marked this pull request as draft June 30, 2022 20:41
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cwillum Looks good to me, I've cross referenced what you've written here with the code and it looks right on point 👍

Yes this document applies to OpenSearch 1.0+ versions (So it should be included in 1.3 and 2.0)

@cwillum cwillum added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x labels Jun 30, 2022
@cwillum cwillum marked this pull request as ready for review June 30, 2022 21:10
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions, otherwise LGTM.

Introduced 1.0
{: .label .label-purple }

Rest API action to reload SSL certificates. It can be used to reload SSL certificates that are about to expire without restarting OpenSearch node.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the format of the other APIs in the file.

Suggested change
Rest API action to reload SSL certificates. It can be used to reload SSL certificates that are about to expire without restarting OpenSearch node.
Reloads SSL certificates that are about to expire without restarting the OpenSearch node.

_security-plugin/access-control/api.md Show resolved Hide resolved
@Naarcha-AWS
Copy link
Collaborator

@cwillum: If you want to get DCO to pass, use the instructions from this page to amend each commit with your signature.

Jeff Huss and others added 3 commits July 1, 2022 14:09
git commit -s -m “fixed#530

Signed-off-by: Moore <[email protected]>
@cwillum
Copy link
Contributor Author

cwillum commented Jul 1, 2022

Closing this PR because I ran into several DCO errors that I couldn't resolve. Opening a new PR in its place.

@cwillum cwillum closed this Jul 1, 2022
@Naarcha-AWS Naarcha-AWS deleted the fix#530 branch July 28, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Tech review PR: Tech review in progress backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants