Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboards]: Change to menu bars #706

Closed
opensearch-trigger-bot bot opened this issue Jun 22, 2022 · 4 comments · Fixed by #760
Closed

[Dashboards]: Change to menu bars #706

opensearch-trigger-bot bot opened this issue Jun 22, 2022 · 4 comments · Fixed by #760
Assignees
Labels
Closed - Complete Issue: Work is done and associated PRs closed dashboards v2.1.0
Milestone

Comments

@opensearch-trigger-bot
Copy link

Is your feature request related to a problem?
A new feature has been added.

What solution would you like?
Document the usage of the new feature.

What alternatives have you considered?
N/A

Do you have any additional context?
See please
opensearch-project/OpenSearch-Dashboards#1586.

@Naarcha-AWS Naarcha-AWS added this to the 2022-Q3 milestone Jun 23, 2022
@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started dashboards labels Jun 23, 2022
@Naarcha-AWS Naarcha-AWS changed the title Add documentation related to new feature [Dashboards]: Change to menu bars Jun 23, 2022
@kavilla
Copy link
Member

kavilla commented Jun 27, 2022

This feature will be released for 2.1

@hdhalter
Copy link
Contributor

@kavilla - Is there any impact to documentation, other than a release note? Thanks.

@kavilla
Copy link
Member

kavilla commented Jun 29, 2022

Hello @hdhalter,

I believe this page should reflect the updated config: https://opensearch.org/docs/latest/dashboards/branding/

@joshuarrrr
Copy link
Member

@hdhalter The new branding config value added is opensearchDashboards.branding.useExpandedHeader, as seen in the new example config:

# opensearchDashboards.branding:
#   logo:
#     defaultUrl: ""
#     darkModeUrl: ""
#   mark:
#     defaultUrl: ""
#     darkModeUrl: ""
#   loadingLogo:
#     defaultUrl: ""
#     darkModeUrl: ""
#   faviconUrl: ""
#   applicationTitle: ""
#   useExpandedHeader: false

It currently defaults to true, which preserves the current behavior of 2 header bars, a top bar with the logo, and a bottom bar that now contains the rest of the existing menu items. (For a demo, see opensearch-project/OpenSearch-Dashboards#1583 (comment))

What users need to know about this new feature and setting:

  1. The general behavior of the top navigation menu changed in v2.1: home button and loading icon changed, help and user management buttons moved (and any other navLinks registered by plugins)
  2. Users who would like to opt-in to the new, condensed header experience can now do so by setting useExpandedHeader: false in their config file. (To help them choose, we should include screenshots of both modes).
  3. In v3.0, the default behavior will change to useExpandedHeader: false, so any users that want to avoid switching to the new condensed can go ahead and explicitly set useExpandedHeader: true in their config now, or they can wait and do it when upgrading.
  4. If users have custom plugins that add menu navLinks, and they'd like those links or buttons to remain on the top menu bar (instead of moving to the bottom bar), as in this example, they must make the following replacements:
    coreStart.chrome.navControls.registerRight(...) with coreStart.chrome.navControls.registerExpandedRight(...)
    and
    coreStart.chrome.navControls.registerCenter(...) with coreStart.chrome.navControls.registerExpandedCenter(...)
    (see [UX] Redesigned Global Header OpenSearch-Dashboards#1583 (comment) for complete steps)

@Naarcha-AWS Naarcha-AWS modified the milestones: 2022-Q3, v2.1.0 Jun 30, 2022
@Naarcha-AWS Naarcha-AWS added 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Tech review PR: Tech review in progress and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started 2 - In progress Issue/PR: The issue or PR is in progress. labels Jul 6, 2022
@hdhalter hdhalter added Closed - Complete Issue: Work is done and associated PRs closed and removed 3 - Tech review PR: Tech review in progress labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed - Complete Issue: Work is done and associated PRs closed dashboards v2.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants