-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] S3 source processes SQS notification when S3 folder is created #3727
Comments
I was able to reproduce it with parquet codec where the error message is slightly different: pipeline:
|
4 tasks
github-project-automation
bot
moved this from Unplanned
to Done
in Data Prepper Tracking Board
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
There is a confusion in s3 source users when source receives notification from SQS on creating S3 folder. S3 sources processes this notifications and tries to get the object from folder, which results in 0 records being created and also logging a warning message along with incrementing
s3ObjectNoRecordsFound
metric.Failed to find any records in S3 object: s3ObjectReference=[bucketName=bucket-name, key=folder-name/].
To Reproduce
Steps to reproduce the behavior:
Failed to find any records in S3 object: s3ObjectReference=[bucketName=bucket-name, key=folder-name/].
Expected behavior
There shouldn't a log that there are no records found in that key, but instead we should skip
getObject
call on this key or have a different log message that it's a folder.There are couple of ways we can achieve this,
S3EventNotification
which contains size.data-prepper/data-prepper-plugins/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/S3EventNotification.java
Line 90 in b6e38a7
/
, I don't see that you can create a key with/
in the key name.We can achieve this by doing the following here
The text was updated successfully, but these errors were encountered: