Fix bug so GLOBAL read-only items do not expire from TTL in ddb source coordination store #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e coordination store Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
chenqi0805
previously approved these changes
Nov 27, 2023
Signed-off-by: Taylor Gray <[email protected]>
dlvenable
approved these changes
Nov 28, 2023
chenqi0805
approved these changes
Nov 28, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
…e coordination store (#3703) Fix bug so GLOBAL read-only items do not expire from TTL in ddb source coordination store Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit c8548a0)
graytaylor0
added a commit
that referenced
this pull request
Nov 28, 2023
…e coordination store (#3703) (#3711) Fix bug so GLOBAL read-only items do not expire from TTL in ddb source coordination store Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit c8548a0) Co-authored-by: Taylor Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the dynamodb source coordination store using
ttlwill update thettlwhenever items are updated to keep them preserved. However, there are some cases where items in the table may be read-only, which means they will never be updated and will expire after thettlno matter what. This would affectdynamodbsource pipelines, as there are 3 GLOBAL read-only items (1 for table details, 1 for export details, 1 for stream details).Tested that the GLOBAL items do not receive an
expirationTimeas TTL with the dynamodb sourceCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.