Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSearch Java client's AwsSdk2Transport #1881

Closed
Tracked by #2169
dlvenable opened this issue Oct 5, 2022 · 2 comments · Fixed by #2385
Closed
Tracked by #2169

Use OpenSearch Java client's AwsSdk2Transport #1881

dlvenable opened this issue Oct 5, 2022 · 2 comments · Fixed by #2385
Assignees
Labels

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

The OpenSearch Java client supports an AWS-based transport (AwsSdk2Transport). Investigate using this when sending requests to Amazon OpenSearch Service.

Describe the solution you'd like

Possibly change to use the AWS transport.

Additional context

Suggested by @dblock in #1877 (comment)

@dlvenable
Copy link
Member Author

To solve this, we can update Data Prepper's ConnectionConfiguration provide a method to create an opensearch-java OpenSearchClient object instead of a rest high-level client.

Change the signature of createClient() method to:

OpenSearchClient createClient() {
  ...
}

When SigV4 is enabled, then ConnectionConfiguration::getClient will use the AwsSdk2Transport. Otherwise, continue to create theRestClientTransport.

With this change we should also remove AwsRequestSigningApacheInterceptor.

@dlvenable
Copy link
Member Author

Because the OTelTraceGroupProcessor class uses createClient() it would need to be updated to use opensearch-java as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants