-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional context in metrics prefix #1789
Comments
Thanks @asifsmohammed, I have a few questions: What are all the metrics for core peer forwarding we plan on supporting/providing to users? Will there be client side metrics we will want to emit for different aggregate processors? This may help with trying to define the syntax as this changes the requirements. Can you elaborate on the solution analysis? What are the cons to the first solution and pros to the alternative approach? |
I like the solution you proposed. One con is that we could have metric name conflicts if users name their pipeline An alternative is to prefix all pipeline metrics with |
I updated list of metrics for core peer forwarder in the issue here. |
Is your feature request related to a problem? Please describe.
Currently
PluginMetrics
publishes metrics with prefix<pipeline-name>.<plugin-name>.<defined-by-plugins>
which adds a restriction to publish any metrics from Data Prepper core peer forwarding or is some cases conditional routing router.Describe the solution you'd like
Make the pipeline-name component more generic, it can be pipeline name / component-scope. Something like
<generic-name>.<component-id>.<defined-metric-name>
. So for metrics from core package we could prefix it by<component-scope>
instead of a<pipeline-name>
.Examples:
Pros:
PluginMetrics
class.Cons:
core
all the metrics will be prefixed withcore
.Describe alternatives you've considered (Optional)
An alternative could be
<pipeline-name>.<component-scope>.<component-id>.<defined-metric-name>
.Examples:
Cons for alternative approach:
Additional context
data-prepper/data-prepper-api/src/main/java/com/amazon/dataprepper/metrics/PluginMetrics.java
Lines 32 to 35 in e3b8a82
The text was updated successfully, but these errors were encountered: