Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external services in the service map #1131

Open
dlvenable opened this issue Mar 1, 2022 · 2 comments
Open

Support external services in the service map #1131

dlvenable opened this issue Mar 1, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request Priority-High

Comments

@dlvenable
Copy link
Member

dlvenable commented Mar 1, 2022

Is your feature request related to a problem? Please describe.

Some services call external services which are not annotated. Data Prepper users still want to see these external services in the service map.

Describe the solution you'd like

Include external service calls in the service map. This issue still needs additional analysis for the solution.

Additional context

Related issue in the OpenSearch Observability plugin: opensearch-project/dashboards-observability#90

Also, see #628 for a related Data Prepper issue which is somewhat the opposite problem.

@dlvenable
Copy link
Member Author

The problem for this issue is that we have spans for an un-instrumented service. Data Prepper should be able to output a service map document which has the external un-instrumented service.

@dlvenable
Copy link
Member Author

Utilizing the peer.service might be appropriate here.

https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/span-general/#general-remote-service-attributes

We've seen some spans that have the following where an external system is used and not included in the service map.

"span.attributes.peer@service": "externalSystem"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority-High
Projects
Development

No branches or pull requests

2 participants