(OUI Next Theme) Query Workbench

[KrooshalUX]

This issue to be transferred to corresponding repository

I am working on launching new light and dark mode themes provided by OUI component library for a target launch within 2.10. These changes support the vision expressed in Future Vision for Dashboards

I have identified the following front end related issues that prevent the theme from appearing complete and potential solutions within this feature:

• When in dark mode, editor appears in light mode

[derek-ho]

@joshuali925 temporarily assigning to you until we figure out how to divide up these tasks - seems like a lot of OUI compliance issues coming our way

[joshuarrrr]

@joshuali925 This should be a pretty quick fix. OpenSearch Dashboards provides a theme-aware customization of the textmate theme for ace editor. See opensearch-project/OpenSearch-Dashboards#4609

Setting the theme to textmate is likely sufficient.

[joshuarrrr]

I see you're using a custom theme defined here: https://github.com/opensearch-project/dashboards-query-workbench/blob/69a91fb0589c422d162018f9a371d93835d7cf74/public/index.scss

This is not recommended, because you'll need to constantly update it based on OUI theme changes.

[joshuarrrr]

If you'd like to sync on this, feel free to sign up for OpenSearch Dashboards developer office hours: https://opensearch.org/events/2023-0921-dev-officehours-dashboards/

[joshuali925]

thanks for the info.

1. should textmate be default in oui?
2. what about completion menu color?

[joshuarrrr]

1. should textmate be default in oui?

It's a little complicated. At the time of forking OSD and OUI, the <EuiCodeEditor> component (which wraps ace) was already marked deprecated, in favor of just using monaco provided by OSD. But almost all code editor instances have yet to be migrated. And the texmate style overrides all currently exist only in the OSD codebase, not OUI. So, for the interim, until we're really ready to do a big migration to monaco, I think the guidance is to just use the modified texmate theme provided by OSD.

2. what about completion menu color?

This should already be styled correctly by the custom OSD textmate theme. If not, we may need to investigate further.

[joshuali925]

Got it, that makes sense.

I tested textmate on workbench and took the screenshot, the completion menu is still light under dark mode, needs more investigation