Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Notebook not isolated according to workspace #2262

Closed
yubonluo opened this issue Nov 25, 2024 · 0 comments
Closed

[BUG] Notebook not isolated according to workspace #2262

yubonluo opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yubonluo
Copy link
Contributor

What is the bug?
When workspace enabled and accessing the Notebooks page, the notebook saved object is not isolated according to the workspace and displays data that does not belong to that workspace.

How can one reproduce the bug?
Steps to reproduce the behavior:
config:

workspace.enabled: true 
savedObjects.permission.enabled: true
opensearchDashboards.dashboardAdmin.users: ["admin"]

uiSettings:
   overrides:
     "home:useNewHomePage": true
  1. Create two workspaces (ws1 and ws2).
  2. Create a notebook test notebook in ws1.
  3. Navigate to ws2 and go to Notebooks page
  4. See the test notebook in the page.

What is the expected behavior?
When accessing notebook page, only the notebook belonging to the workspace should be displayed.

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
image

Do you have any additional context?
When call http://localhost:5601/w/dODCAo/api/observability/notebooks/savedNotebook/ will redirect to http://localhost:5601/api/observability/notebooks/savedNotebook/ which resulting in the lack of workspace information.
One solution is to remove the last / in https://github.com/opensearch-project/dashboards-observability/blob/main/public/components/notebooks/components/main.tsx#L111

@yubonluo yubonluo added bug Something isn't working untriaged labels Nov 25, 2024
@yubonluo yubonluo changed the title [BUG] [BUG] Notebook not isolated according to workspace Nov 25, 2024
@ps48 ps48 removed the untriaged label Nov 27, 2024
@ps48 ps48 self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants