Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Split multiple plugins into their own repositories #95

Closed
Tracked by #142 ...
dblock opened this issue Nov 28, 2022 · 6 comments
Closed
Tracked by #142 ...

[BUG] Split multiple plugins into their own repositories #95

dblock opened this issue Nov 28, 2022 · 6 comments
Assignees

Comments

@dblock
Copy link
Member

dblock commented Nov 28, 2022

What is the bug?

Coming from opensearch-project/opensearch-build#2934 (comment) and opensearch-project/opensearch-build#2188, it looks like we have a monorepo being developed here in a feature branch.

https://github.com/opensearch-project/dashboards-maps/tree/main/custom_import_map
https://github.com/opensearch-project/dashboards-maps/tree/feature/new-maps/maps_dashboards

What is the expected behavior?

Split monorepo into full, standalone plugin repos.

@navneet1v
Copy link
Collaborator

navneet1v commented Nov 28, 2022

@dblock what is the issue with having more than 1 plugin in a repo?

Both the plugins are OSD plugins.

@navneet1v
Copy link
Collaborator

Tagging @CEHENKLE.

@dblock
Copy link
Member Author

dblock commented Jan 5, 2023

@dblock what is the issue with having more than 1 plugin in a repo?

Both the plugins are OSD plugins.

Apologies for the late reply, didn't see the tag. Take a look at opensearch-project/opensearch-build#2188 and the long discussion in it.

@heemin32
Copy link
Collaborator

heemin32 commented Jan 5, 2023

@dblock what is the issue with having more than 1 plugin in a repo?
Both the plugins are OSD plugins.

Apologies for the late reply, didn't see the tag. Take a look at opensearch-project/opensearch-build#2188 and the long discussion in it.

Hi @dblock, in the thread, you mentioned that The intention of this issue was to split front-end and back-end plugins, for those other things I'd defer to the team that understands the code dependencies better. Maybe open another issue on those? How often do they release and what are their dependencies?. In our case, both are front-end. We are not having front-end and back-end plugin in a single repo.

@navneet1v
Copy link
Collaborator

We are not having front-end and back-end plugin in a single repo.

Hi @heemin32
I have clarified with @dblock on this. The time when the proposal was created it was for splitting the repos having frontend and backend plugins. But on based on recent updates, the proposal is valid for this repo too.

@VijayanB
Copy link
Member

Now both plugins are merged into single plugin. Thanks @dblock for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants